Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SDK Tracer/Meter/Logger Creation more normative #3529

Merged
merged 15 commits into from
Jun 26, 2023
Merged

Make SDK Tracer/Meter/Logger Creation more normative #3529

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f93819d
Make SDK Meter Creation more normative
pellared Jun 2, 2023
f6963ea
Make it more normative
pellared Jun 2, 2023
db85dbd
Update sdk.md
pellared Jun 2, 2023
6e3b581
Merge branch 'main' into patch-5
pellared Jun 5, 2023
c99692b
Update SDK Tracer Creation
pellared Jun 5, 2023
41b1555
Update SDK Logger Creation
pellared Jun 5, 2023
3617e6a
Merge branch 'main' into patch-5
pellared Jun 6, 2023
ee8df14
Merge branch 'main' into patch-5
pellared Jun 7, 2023
65201df
Apply suggestions from code review
pellared Jun 12, 2023
56b2bef
Update CHANGELOG.md
pellared Jun 12, 2023
11e4518
Merge branch 'main' into patch-5
pellared Jun 12, 2023
0910a69
Merge branch 'main' into patch-5
pellared Jun 16, 2023
d2f6927
Merge branch 'main' into patch-5
pellared Jun 23, 2023
7d0e75f
Place "only" in the correct place
pellared Jun 26, 2023
8867979
Merge branch 'main' into patch-5
pellared Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions specification/logs/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,12 @@ The SDK SHOULD allow the creation of multiple independent `LoggerProviders`s.

### Logger Creation

New `Logger` instances are always created through a `LoggerProvider`
(see [Bridge API](bridge-api.md)). The `name`, `version` (optional),
`schema_url` (optional), and `attributes` (optional) supplied to
the `LoggerProvider` must be used to create
It SHOULD be possible to create `Logger` instances only through a `LoggerProvider`
reyang marked this conversation as resolved.
Show resolved Hide resolved
(see [Bridge API](bridge-api.md)).

The `LoggerProvider` MUST implement the [Get a Logger Bridge API](bridge-api.md#get-a-logger).
pellared marked this conversation as resolved.
Show resolved Hide resolved

The input provided by the user MUST be used to create
an [`InstrumentationScope`](../glossary.md#instrumentation-scope) instance which
is stored on the created `Logger`.

Expand Down
10 changes: 6 additions & 4 deletions specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,12 @@ The SDK SHOULD allow the creation of multiple independent `MeterProvider`s.

### Meter Creation

New `Meter` instances are always created through a `MeterProvider`
(see [API](./api.md#meterprovider)). The `name`, `version` (optional),
`schema_url` (optional), and `attributes` (optional) arguments supplied to
the `MeterProvider` MUST be used to create
It SHOULD be possible to create `Meter` instances only through a `MeterProvider`
pellared marked this conversation as resolved.
Show resolved Hide resolved
(see [API](./api.md#meterprovider)).
jack-berg marked this conversation as resolved.
Show resolved Hide resolved

The `MeterProvider` MUST implement the [Get a Meter API](api.md#get-a-meter).

The input provided by the user MUST be used to create
cijothomas marked this conversation as resolved.
Show resolved Hide resolved
an [`InstrumentationScope`](../glossary.md#instrumentation-scope) instance which
is stored on the created `Meter`.

Expand Down
10 changes: 6 additions & 4 deletions specification/trace/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,12 @@

### Tracer Creation

New `Tracer` instances are always created through a `TracerProvider`
(see [API](api.md#tracerprovider)). The `name`, `version` (optional),
`schema_url` (optional), and `attributes` (optional) arguments supplied to
the `TracerProvider` must be used to create
It SHOULD be possible to create `Tracer` instances only through a `TracerProvider`
(see [API](./api.md#tracerprovider)).

The `TracerProvider` MUST implement the [Get a Tracer API](api.md#get-a-tracer).

The input provided by the user MUST be used to create
an [`InstrumentationScope`](../glossary.md#instrumentation-scope) instance which
is stored on the created `Tracer`.

Expand Down