Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editorial] Normalize links in semconv/http-metrics #3498

Conversation

chalin
Copy link
Contributor

@chalin chalin commented May 11, 2023

@chalin chalin requested review from a team May 11, 2023 14:06
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't the notice at the top of this document prevent changes to this file?

@chalin
Copy link
Contributor Author

chalin commented May 11, 2023

It would be nice to be able to fix build warnings before freezing the file. Besides, this is an editorial change. But it your (spec approvers) call.

/cc @svrnm @cartermp

@reyang
Copy link
Member

reyang commented May 11, 2023

@jsuereth I'll leave it to you to decide whether to merge it here or not (if we merge it, we'll need to port the change to the semantic-conventions repo).

@reyang reyang requested a review from jsuereth May 11, 2023 17:47
@reyang reyang assigned jsuereth and unassigned jmacd May 11, 2023
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this PR. It's a nice to have, but these files will be slowly "tore down" and pointed to the new semconv repository.

The goal of "prior to 1.21" release is a no-go. We're not releasing semantic conventions are part of 1.21, that release has moved to the new repository.

@reyang reyang added area:semantic-conventions Related to semantic conventions editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. labels May 11, 2023
@chalin
Copy link
Contributor Author

chalin commented May 11, 2023

Blocking this PR.

Ok, no problem. Shall we just close this PR?

It's a nice to have, but these files will be slowly "tore down" and pointed to the new semconv repository.

Ok, got it.

... We're not releasing semantic conventions are part of 1.21, that release has moved to the new repository.

If I understand correctly, the semconv pages will be / have been pulled out of the spec? If so, could you open an issue similar to the following:

... but for the semconv, so that I can prepare for the page removal on the website side -- and so that we can have a place to discuss whether we still want the semconv pages to be publish on the website in how. If you rather, I can create the issue once you confirm the page move, just let me know.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 19, 2023
@chalin chalin closed this May 24, 2023
@chalin chalin deleted the chalin-im-http-metrics-normalize-links-2023-05-11 branch May 24, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants