-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[editorial] Normalize links in semconv/http-metrics #3498
[editorial] Normalize links in semconv/http-metrics #3498
Conversation
chalin
commented
May 11, 2023
- Clean up in prep for next release of spec
- In scope of CI: external-link check follow up and link cleanup opentelemetry.io#2429
- Related: Misc. spec-compliance-matrix updates for Ruby #2642
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't the notice at the top of this document prevent changes to this file?
@jsuereth I'll leave it to you to decide whether to merge it here or not (if we merge it, we'll need to port the change to the semantic-conventions repo). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking this PR. It's a nice to have, but these files will be slowly "tore down" and pointed to the new semconv repository.
The goal of "prior to 1.21" release is a no-go. We're not releasing semantic conventions are part of 1.21, that release has moved to the new repository.
Ok, no problem. Shall we just close this PR?
Ok, got it.
If I understand correctly, the semconv pages will be / have been pulled out of the spec? If so, could you open an issue similar to the following: ... but for the semconv, so that I can prepare for the page removal on the website side -- and so that we can have a place to discuss whether we still want the semconv pages to be publish on the website in how. If you rather, I can create the issue once you confirm the page move, just let me know. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |