Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ChangeLog to include v0.2.0 #333

Merged
merged 4 commits into from
Oct 26, 2019
Merged

Update ChangeLog to include v0.2.0 #333

merged 4 commits into from
Oct 26, 2019

Conversation

tedsuo
Copy link
Contributor

@tedsuo tedsuo commented Oct 22, 2019

I believe I captured all of the major changes. Did I miss anything?

Copy link
Member

@iredelmeier iredelmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested/asked about a couple things but it also LGTM as is.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @iredelmeier that it will be logical to mention OTEPs inline

@SergeyKanzhelev
Copy link
Member

Also fix a build please

@SergeyKanzhelev
Copy link
Member

@tedsuo ping

@tedsuo
Copy link
Contributor Author

tedsuo commented Oct 25, 2019

@iredelmeier @SergeyKanzhelev
Here you go! I consolidated the OTEPs into the list, as requested. I agree, it looks better this way.

I did not feel like most changes would easily land in only one of add/removed/changed, so I just kept it as a single list. Open to better formatting though.

@SergeyKanzhelev
Copy link
Member

Active for more than 2 days. Have enough reviews. And not a semantics change. Merging

@SergeyKanzhelev SergeyKanzhelev merged commit 6e8fdd8 into open-telemetry:master Oct 26, 2019
SergeyKanzhelev pushed a commit to SergeyKanzhelev/opentelemetry-specification that referenced this pull request Feb 18, 2020
* v0.2.0 added to ChangeLog

* Consolidate OPEP list into list of changes

* Past tense for everything
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
* v0.2.0 added to ChangeLog

* Consolidate OPEP list into list of changes

* Past tense for everything
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants