Expand scope of `faas.id` to `cloud.resource_id` #3188

tylerbenson · 2023-02-08T18:10:53Z

Changes

As per the discussion on #3188, we determined it is better to move rather than remove as this attribute is still important for some systems despite it containing duplicated information.

semantic_conventions/resource/faas.yaml

cartersocha · 2023-02-10T22:25:59Z

CC: @lmolkova, @dashpole, @reyang. The unique resource ID conversation(s) above in particular will need cloud SMEs. While changing the faas spec in general we've concluded some of changes will be better placed in cloud requirements rather than FAAS.

tylerbenson · 2023-02-14T20:33:46Z

FYI. I've pulled the first two commits out into a separate PR #3209. I'll try moving faas.id over to the cloud spec as cloud.resource_id instead of just removing it in this PR. Thanks everyone for the feedback.

As per the discussion on open-telemetry#3188, we determined it is better to move rather than remove as this attribute is still important for some systems despite it containing duplicated information.

carlosalberto · 2023-02-16T21:23:01Z

Hey @Oberon00

I'm OK with leaving the primary definition here, but we should still ref this from the FaaS conventions IMHO as it's quite important.

You mean adding a reference/link from the FaaS semconv table to this section?

Co-authored-by: Christian Neumüller <[email protected]>

carlosalberto · 2023-02-17T15:39:05Z

Btw @Oberon00

Following on this: once we decide how to proceed with open-telemetry/oteps#222 we should also double check expectations here regarding ECS.

FWIW I think ECS is a better, clearer, cleaner semconv reference, with faas with IMHO the exception (e.g. faas.execution created lots of confusion among users)

Oberon00 · 2023-02-20T10:34:15Z

You mean adding a reference/link from the FaaS semconv table to this section?

Exactly (using the ref mechanism in the YAML definition of the FaaS table)

Oberon00 · 2023-02-20T10:35:54Z

Following on this: once we decide how to proceed with open-telemetry/oteps#222 we should also double check expectations here regarding ECS.

I think you should decide on this rather sooner than later otherwise lots of work on the semantic conventions (such as this PR) and also potentially the tooling may go to waste.

# Conflicts: # schemas/1.19.0 # specification/resource/semantic_conventions/faas.md # specification/trace/semantic_conventions/faas.md # specification/trace/semantic_conventions/instrumentation/aws-lambda.md

specification/trace/semantic_conventions/instrumentation/aws-lambda.md

## Changes As per the discussion on open-telemetry#3188, we determined it is better to move rather than remove as this attribute is still important for some systems despite it containing duplicated information.

These places were removed when open-telemetry#3188 in its original form removed faas.id without replacement and weren't added back after changing it to introduce cloud.resource_id instead.

These places were removed when #3188 in its original form removed faas.id without replacement and weren't added back after changing it to introduce cloud.resource_id instead. Editorial change, no CHANGELOG or issue.

…26486) Context: GoogleCloudPlatform/opentelemetry-operations-go#679 faas.id was removed from the semantic conventions: open-telemetry/opentelemetry-specification#3188 We were previously using it improperly to store the instance id of the faas, which should be mapped to faas.instance instead. --------- Co-authored-by: Alex Boten <[email protected]>

…pen-telemetry#26486) Context: GoogleCloudPlatform/opentelemetry-operations-go#679 faas.id was removed from the semantic conventions: open-telemetry/opentelemetry-specification#3188 We were previously using it improperly to store the instance id of the faas, which should be mapped to faas.instance instead. --------- Co-authored-by: Alex Boten <[email protected]>

## Changes As per the discussion on open-telemetry#3188, we determined it is better to move rather than remove as this attribute is still important for some systems despite it containing duplicated information.

…etry#3329) These places were removed when open-telemetry#3188 in its original form removed faas.id without replacement and weren't added back after changing it to introduce cloud.resource_id instead. Editorial change, no CHANGELOG or issue.

tylerbenson requested review from a team February 8, 2023 18:10

github-actions bot assigned jmacd Feb 8, 2023

tylerbenson force-pushed the tyler/faas branch from 46cc53f to a2aa3bb Compare February 8, 2023 18:12

tsloughter approved these changes Feb 8, 2023

View reviewed changes

jmacd approved these changes Feb 8, 2023

View reviewed changes

semantic_conventions/resource/faas.yaml Outdated Show resolved Hide resolved

Oberon00 previously requested changes Feb 9, 2023

View reviewed changes

semantic_conventions/resource/faas.yaml Show resolved Hide resolved

semantic_conventions/resource/faas.yaml Show resolved Hide resolved

arminru added area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory spec:trace Related to the specification/trace directory spec:metrics Related to the specification/metrics directory labels Feb 9, 2023

lmolkova approved these changes Feb 13, 2023

View reviewed changes

tylerbenson mentioned this pull request Feb 14, 2023

Rename faas.execution to faas.invocation_id and change units for faas.max_memory #3209

Merged

tylerbenson force-pushed the tyler/faas branch from fa58b5e to a2db39a Compare February 14, 2023 22:01

tylerbenson changed the title ~~FAAS SIG spec changes~~ Expand scope of faas.id to cloud.resource_id Feb 14, 2023

Expand scope of faas.id to cloud.resource_id

71d6dac

As per the discussion on open-telemetry#3188, we determined it is better to move rather than remove as this attribute is still important for some systems despite it containing duplicated information.

tylerbenson force-pushed the tyler/faas branch from a2db39a to 71d6dac Compare February 14, 2023 22:05

tylerbenson requested review from Oberon00, lmolkova and jmacd and removed request for Oberon00, lmolkova and jmacd February 14, 2023 22:06

an -> a

89a8207

tylerbenson and others added 2 commits February 16, 2023 17:08

Added ref: cloud.resource_id

8b51c24

Apply stronger wording.

873fda5

Co-authored-by: Christian Neumüller <[email protected]>

tylerbenson added 2 commits February 21, 2023 11:33

Fix yaml format/alignment

a75e253

Merge branch 'main' into tyler/faas

6daf9ed

# Conflicts: # schemas/1.19.0 # specification/resource/semantic_conventions/faas.md # specification/trace/semantic_conventions/faas.md # specification/trace/semantic_conventions/instrumentation/aws-lambda.md

Oberon00 reviewed Feb 22, 2023

View reviewed changes

specification/trace/semantic_conventions/instrumentation/aws-lambda.md Show resolved Hide resolved

tylerbenson and others added 2 commits February 22, 2023 11:23

Review request

a7fc7f6

Merge branch 'main' into tyler/faas

bc0ff89

carlosalberto merged commit c00654c into open-telemetry:main Feb 27, 2023

tylerbenson deleted the tyler/faas branch February 27, 2023 20:50

MrAlias mentioned this pull request Mar 6, 2023

Generate v1.19.0 semconv open-telemetry/opentelemetry-go#3842

Closed

lmolkova mentioned this pull request Mar 7, 2023

Code generation fails for SEMCONV 1.19.0 #3299

Closed

Oberon00 mentioned this pull request Mar 21, 2023

Add back refs to cloud.resource_id lost in FaaS renaming. #3329

Merged

Oberon00 mentioned this pull request Apr 19, 2023

Analyze the overlap between OpenTelemetry tracing attributes and ECS attributes open-telemetry/semantic-conventions#1012

Closed

5 tasks

damemi mentioned this pull request Jul 18, 2023

Update usages of faas.id resource attribute to faas.instance GoogleCloudPlatform/opentelemetry-operations-go#679

Closed

dyladan mentioned this pull request Jul 19, 2023

Update semconv to 1.21.0 open-telemetry/opentelemetry-js#4009

Closed

dashpole mentioned this pull request Sep 6, 2023

Switch from detecting faas.id to faas.instance in the gcp detector. open-telemetry/opentelemetry-collector-contrib#26486

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expand scope of `faas.id` to `cloud.resource_id` #3188

Expand scope of `faas.id` to `cloud.resource_id` #3188

tylerbenson commented Feb 8, 2023 •

edited

Loading

cartersocha commented Feb 10, 2023

tylerbenson commented Feb 14, 2023 •

edited

Loading

carlosalberto commented Feb 16, 2023

carlosalberto commented Feb 17, 2023 •

edited

Loading

Oberon00 commented Feb 20, 2023

Oberon00 commented Feb 20, 2023 •

edited

Loading

Expand scope of faas.id to cloud.resource_id #3188

Expand scope of faas.id to cloud.resource_id #3188

Conversation

tylerbenson commented Feb 8, 2023 • edited Loading

Changes

cartersocha commented Feb 10, 2023

tylerbenson commented Feb 14, 2023 • edited Loading

carlosalberto commented Feb 16, 2023

carlosalberto commented Feb 17, 2023 • edited Loading

Oberon00 commented Feb 20, 2023

Oberon00 commented Feb 20, 2023 • edited Loading

Expand scope of `faas.id` to `cloud.resource_id` #3188

Expand scope of `faas.id` to `cloud.resource_id` #3188

tylerbenson commented Feb 8, 2023 •

edited

Loading

tylerbenson commented Feb 14, 2023 •

edited

Loading

carlosalberto commented Feb 17, 2023 •

edited

Loading

Oberon00 commented Feb 20, 2023 •

edited

Loading