Add http.client_scheme #3179
Closed
Add http.client_scheme #3179
+41
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blumamir
reviewed
Feb 7, 2023
| brief: > | ||
| The http scheme of the original client behind all proxies, if | ||
| known (e.g. from [X-Forwarded-Proto](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-Proto) | ||
| or [Forwarded](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Forwarded)). |
There was a problem hiding this comment.
As I wrote in the issue, this attribute will require the instrumentations to parse the header and extract the protocol from it to store.
In addition, it will create duplication of the value if the user is also recording the headers.
As this can also be done later in the pipeline, I suggest considering the use of http.request.header.x-forwarded-proto / http.request.header.forwarded which is an existing attribute that records the relevant information (or allow instrumentation to set either one of these attributes).
|
Closing this in favor of a future PR that incorporates the ideas from @lmolkova's #2338 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping as draft for now to discuss
http.client_ipvshttp.forwarded_ipin HTTP semconv stability WG.Fixes #2338
Changes
Add new http attribute
http.client_schemeto capture original client scheme, e.g. when using SSL-terminating web server in front of application.