Add db.values #3091
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,16 +6,17 @@ | |
|
|
||
| <!-- toc --> | ||
|
|
||
| - [Semantic conventions for database client calls](#semantic-conventions-for-database-client-calls) | ||
|
There was a problem hiding this comment. Did you run the markdown generator tool or change this manually? I think the build is failing because of it. The top-level page title is not in the table of contents I think, so the diff does not match. There was a problem hiding this comment. Sorry, I was sure I closed this PR. I thought I only need to change the yaml file, but according to your comment, I'll read the CONTRIBUTING.md file and act accordingly. There was a problem hiding this comment. I'm a bit confused 😅 which PR is the "real" one? This or #3092? Can you close the one that's obsolete now? |
||
| - [Connection-level attributes](#connection-level-attributes) | ||
| - [Notes and well-known identifiers for `db.system`](#notes-and-well-known-identifiers-for-dbsystem) | ||
| - [Connection-level attributes for specific technologies](#connection-level-attributes-for-specific-technologies) | ||
| - [Call-level attributes](#call-level-attributes) | ||
| - [Call-level attributes for specific technologies](#call-level-attributes-for-specific-technologies) | ||
| - [Cassandra](#cassandra) | ||
| - [Examples](#examples) | ||
| - [MySQL](#mysql) | ||
| - [Redis](#redis) | ||
| - [MongoDB](#mongodb) | ||
|
|
||
| <!-- tocstop --> | ||
|
|
||
|
|
@@ -265,4 +266,4 @@ Furthermore, `db.name` is not specified as there is no database name in Redis an | |
| | `db.name` | `"shopDb"` | | ||
| | `db.statement` | not set | | ||
| | `db.operation` | `"findAndModify"` | | ||
| | `db.mongodb.collection` | `"products"` | | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to indicate here how this can be turned off? Is it something "speced" or it differs from instrumentation to instrumentation? And I guess the "data sensitivity" concern with these values are protected somehow by this opt-in configuration?