Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTracing Shim: Add Tracer.Close() operation. #3048

Merged
merged 15 commits into from
Jan 13, 2023
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ release.

### Compatibility

- Add Tracer.Close() to the OpenTracing Shim layer.

### OpenTelemetry Protocol

### SDK Configuration
Expand Down
7 changes: 7 additions & 0 deletions specification/compatibility/opentracing.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
* [Start a new Span](#start-a-new-span)
* [Inject](#inject)
* [Extract](#extract)
* [Close](#close)
* [Span Shim and SpanContext Shim relationship](#span-shim-and-spancontext-shim-relationship)
* [Span Shim](#span-shim)
* [Get Context](#get-context)
Expand Down Expand Up @@ -205,6 +206,12 @@ Errors MAY be raised if either the `Format` is not recognized
or no value could be extracted, depending on the specific OpenTracing Language API
(e.g. Go and Python do, but Java may not).

## Close

Optional operation. If this operation is implemented for a specific OpenTracing language,
carlosalberto marked this conversation as resolved.
Show resolved Hide resolved
it MUST close the underlying `TracerProvider` if it implements a "closeable" interface or method;
jmacd marked this conversation as resolved.
Show resolved Hide resolved
otherwise it MUST be defined as a no-op operation.

## Span Shim and SpanContext Shim relationship

As per the OpenTracing Specification, the OpenTracing `SpanContext` Shim
Expand Down