-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add semantic conventions for log record ID #3047
Add semantic conventions for log record ID #3047
Conversation
Signed-off-by: svrnm <[email protected]>
Signed-off-by: svrnm <[email protected]>
Should we call this |
works for me, I just picked |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
I agree. We already have |
Signed-off-by: svrnm <[email protected]>
Signed-off-by: svrnm <[email protected]>
Co-authored-by: Joao Grassi <[email protected]>
Co-authored-by: Joao Grassi <[email protected]>
Co-authored-by: Joao Grassi <[email protected]>
Co-authored-by: Joao Grassi <[email protected]>
Signed-off-by: svrnm <[email protected]>
anything missing to get this merged? TY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think we should define how these can be automatically added by the SDK. Opened #3277 with a suggestion on how we might do so with another built-in LogRecordProcessor. Can add in a separate PR.
Thank you. |
Co-authored-by: Joao Grassi <[email protected]>
Signed-off-by: svrnm <[email protected]>
Anything missing before this can be merged? TY |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
/unstale |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Thank you for the PR and for your patience @svrnm |
Fixes #597
Changes
Please provide a brief description of the changes here.
log_record.id
making use of ULID as discussed in Decide if we need log record ID field #597Some additional notes: