-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Folder structure and placeholders for defining event schemas (for RUM events as a start) #2933
Conversation
tagging myself |
@scheler, @martinkuba, @MSNev Pl. review. |
Do we want this in the spec? Why isn't it defined in the JS SIG's documentation? Is this applicable to more than one language? |
Yes, that is what the RUM SIG desires. IMO, this is schema, and putting it inside a specific language repo doesn't help discoverability much. Also, as part of RUM we intend to define other events for clients in general. Those schemas would anyway end up in the spec (or another common location) repo. Keeping everything organized here would help drive consistency across client schemas. |
In addition to what Ram said, it will also help us in leveraging the tools built for semantic conventions. These are semantic conventions and we already have browser and mobile specific conventions in the spec repo. |
@ramthi a few things -
|
@ramthi Another thing to note is that these are only semantic conventions and not strictly schema defining the shape of Events. That is out of scope for both OpenTelemetry semantic conventions and OpenTelemetry schemas. If we want the schema to define the shape of Events, then that will be a new feature addition to the spec. |
I am concerned about the following:
@jsuereth what do you think? |
@tigrannajaryan RUM is not just browser apps monitoring, it includes mobile apps as well and potentially IoT in the future. The mobile apps use opentelemetry-java and opentelemetry-swift. It will be good to have the conventions for all of these in one place. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
@jsuereth I think this is a topic for Semantic Convention WG to make a call on. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
This PR is to approve the folder structure for documenting various event schemas. The RUM SIG had been working on defining schemas for various RUM events.
The WIP documents are here:
https://docs.google.com/document/d/1_5MtDy_8uovK3cQEmwrVmFz0ApLQvQGsYX4ME9Kl3pg/edit#heading=h.nbj5nuoe6d1n
https://docs.google.com/spreadsheets/d/1WEIhp7EX6nOg6eJPg6V5OrIPE8EE-oRD4KoiK_6XBF0/edit#gid=267654663
The folder structure follows ../logs/semantic_conventions//.md format.
For the
browser
domain there are standard set of attributes/fields. We want to define these in the common.md file to avoid redundancy. The common. md is referenced in each of the event schemas in the attributes table.The attributes listed in these event schemas will be nested attributes under the event.data field. Pl. refer to this (PR)[https://github.com//pull/2926] for the proposal to add event.data nested attribute.