Add redis resource #2836
Add redis resource #2836
Conversation
update CHANGELOG.md and README.md for redis resource semantic convention added db.redis.instance semantic convention added db.redis.instance attribute
| @@ -532,6 +532,8 @@ release. | |||
| conventions. ([#2272](https://github.com/open-telemetry/opentelemetry-specification/pull/2272)) | |||
| - Add opentracing.ref_type semantic convention. | |||
| ([#2297](https://github.com/open-telemetry/opentelemetry-specification/pull/2297)) | |||
| - Add `db.redis.instance` Resource attribute in Redis. | |||
There was a problem hiding this comment.
I'll add this PR here before moving out of draft
#2836
hughesjj
force-pushed
the
add_redis_resource
branch
from
853511c to
9d5eb3f
Compare
| @@ -89,7 +89,7 @@ release. | |||
| ([#2676](https://github.com/open-telemetry/opentelemetry-specification/pull/2676)) | |||
| - Align log SDK and API component naming | |||
| ([#2768](https://github.com/open-telemetry/opentelemetry-specification/pull/2768)). | |||
| - Add the signal-specific OTEL_EXPORTER_OTLP_LOGS_* environment variables | |||
| - Add the signal-specific OTEL*EXPORTER_OTLP_LOGS*\* environment variables | |||
There was a problem hiding this comment.
Please don't make changes that are not directly relevant to the PR. It would be great if you could submit these fixes as a separate PR.
|
This issue open-telemetry/semantic-conventions#713 might affect/be relevant here |
| @@ -0,0 +1,14 @@ | |||
| groups: | |||
| - id: redis | |||
There was a problem hiding this comment.
Isn't this PR having the same "issue" as the original PR: #2145 (comment)
Did you use this approach as a "workaround" for the conflict as here #2145 (comment)
or is the intention to have redis as a "top-level" entry? If it's because it's a workaround, then maybe we should look into the generator more, or find another way to generate it.
| @@ -0,0 +1,13 @@ | |||
| # Redis | |||
There was a problem hiding this comment.
We already have Redis-specific conventions in database.md. Do we need to introduce a new file just for Redis?
There was a problem hiding this comment.
After talking with Joao and verifying on my end, it looks like you're correct and we can indeed use the existing file even though it's under a different "path" with the "traces".
|
Closing due to
|
Changes
Adds a Redis resource for
db.instancetype as the first step to collecting Redis metrics (not traces). See #2840HUGE note of context: These changes are resurrected from a long-closed but much discussed PR. Regrettably, the original author is not here to Shepard these changes to release, but I believe I've got his work working again.
I don't see anyone having implemented such functionality since, but some have tried.
https://github.com/open-telemetry/opentelemetry-specification/pulls?q=is%3Apr+redis+
Testing
Related Links