Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align log sdk naming with api #2768
Align log sdk naming with api #2768
Changes from all commits
2947f40
50d5955
76403fa
c17f585
9b7fb20
fea438f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jack-berg @scheler
Can you clarify for me what to do in the case of missing
event.domain
to the EmitEvent call? Is it a no-op or a throw? Do I generate a log to alert the user?Also, is it valid if
name
is passed asnull
or empty?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CodeBlanch both
domain
andname
are required for anEvent
and also cannot be empty or null. So EmitEvent call should throw an error ifevent.domain
attribute is missing or is null/empty. Same withname
- if it is null or empty, EmitEvent should return failure or throw an error.