Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JS metrics status in spec compliance matrix #2662

Merged
merged 4 commits into from
Jul 30, 2022

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Jul 14, 2022

Changes

  • Update JavaScript metric status in the spec compliance matrix.

/cc @open-telemetry/javascript-approvers

@legendecas legendecas requested review from a team July 14, 2022 14:40
@jmacd jmacd assigned jmacd and unassigned carlosalberto Jul 14, 2022
@carlosalberto
Copy link
Contributor

@pichlermarc @open-telemetry/javascript-approvers please confirm.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment that I'm not sure about. Everything else looks good. 🙂

spec-compliance-matrix.md Show resolved Hide resolved
# Conflicts:
#	spec-compliance-matrix.md
@legendecas
Copy link
Member Author

Updated with the main branch. Conflicts resolved.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🙂

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 30, 2022
@reyang reyang merged commit 43ae6ed into open-telemetry:main Jul 30, 2022
@legendecas legendecas deleted the js-metrics-compliance branch July 30, 2022 05:47
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants