Upgrade semconv generator to v0.8.0 #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
force-pushed
the
upgrade-semcov-tools-to080
branch
from
495a44e to
5ca172e
Compare
tigrannajaryan
approved these changes
Dec 22, 2021
|
This PR seems to only point the documentation to 0.8.0, the actual build uses opentelemetry-specification/Makefile Lines 12 to 14 in 9216eb8 |
Oberon00
added
area:semantic-conventions
|
@Oberon00 thanks! I fixed it. Can you please take a look? |
Oberon00
approved these changes
Dec 23, 2021
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
carlosalberto
approved these changes
Jan 3, 2022
bogdandrutu
approved these changes
Jan 3, 2022
chalin
reviewed
Feb 15, 2022
Comment on lines
103
to
+106
| The event name MUST be `"message"`. | ||
|
|
||
| <!-- semconv rpc.message --> | ||
| The event name MUST be `message`. |
There was a problem hiding this comment.
The sentence "The event name MUST be message" is repeated twice (though once with quotes). I'm assuming that 103 is superfluous?
chalin
added a commit
to chalin/opentelemetry-specification
that referenced
this pull request
Feb 15, 2022
SergeyKanzhelev
pushed a commit
that referenced
this pull request
Feb 15, 2022
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Upgrade semconv generator to v0.8.0 * update specs with semconv gen 0.8.0 * makefile
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks #2233 by allowing empty prefix in semconv generator (open-telemetry/build-tools#67)
Generator changelog: v0.8.0