Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics SDK - consolidate the aggregation/aggregator term #2153

Merged
merged 4 commits into from
Nov 29, 2021
Merged

Metrics SDK - consolidate the aggregation/aggregator term #2153

merged 4 commits into from
Nov 29, 2021

Conversation

reyang
Copy link
Member

@reyang reyang commented Nov 23, 2021 •
edited
Loading

Fixes part of #2149.

Changes:

  • replace "aggregator" with "aggregation"
  • rewrap lines
  • add a note to recommend implementers to reserve the "aggregator" term for future use

@reyang reyang requested review from a team November 23, 2021 17:28
@reyang reyang added the release:required-for-ga Must be resolved before GA release, or nice to have before GA label Nov 23, 2021
@reyang reyang added this to the Metrics API/SDK Stable Release milestone Nov 23, 2021
This was referenced Nov 24, 2021
Closed
Open
@bogdandrutu
Copy link
Member

Please rebase

@reyang reyang force-pushed the reyang/metrics-sdk-aggregation-term branch from 427977a to 7112cd5 Compare November 24, 2021 23:43
@reyang
Copy link
Member Author

reyang commented Nov 24, 2021

Please rebase

Done.

@reyang reyang added spec:metrics Related to the specification/metrics directory area:sdk Related to the SDK labels Nov 29, 2021
@jsuereth jsuereth merged commit 1d79ac7 into open-telemetry:main Nov 29, 2021
@pirgeo pirgeo mentioned this pull request Nov 30, 2021
Closed
6 tasks
@reyang reyang deleted the reyang/metrics-sdk-aggregation-term branch April 17, 2022 00:48
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@reyang @jmacd
Metrics SDK - consolidate the aggregation/aggregator term (open-telem…
929dbd8 
…etry#2153)

* Metrics SDK - consolidate the aggregation/aggregator term

* add a note to reserve aggregator term

* rewrap

Co-authored-by: Joshua MacDonald <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirgeo pirgeo pirgeo approved these changes

@MrAlias MrAlias MrAlias approved these changes

@cijothomas cijothomas cijothomas approved these changes

@jmacd jmacd jmacd approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@jsuereth jsuereth jsuereth approved these changes

Assignees

@carlosalberto carlosalberto

Labels
area:sdk Related to the SDK release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
Metrics API/SDK Stable Release
Development

Successfully merging this pull request may close these issues.
8 participants
@reyang @bogdandrutu @jsuereth @carlosalberto @jmacd @cijothomas @MrAlias @pirgeo