Add markdown-toc to CI checks #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
make-markdown-toc
branch
from
cd69d96 to
7d9ca4f
Compare
djaglowski
commented
Oct 14, 2021
|
Is this trying to compete with #2020 I pushed today? |
|
Just a coincidence. I was working on markdowns in this repo for the first time yesterday and had to spend a little time getting tooling set up, so it occurred to me to address it. Your implementation is more nuanced than mine, so I'll assume it's preferable. I'll close this PR and, once yours is merged, will open a new one for the CI check. |
|
@djaglowski I think your PR had certain pieces missing from mine, most importantly the integration with the CI. My PR was merged, can you pull it in and add your changes on top? |
|
@yurishkuro I've pulled in your changes and reopened this PR for the CI check. |
yurishkuro
approved these changes
Oct 15, 2021
yurishkuro
reviewed
Oct 15, 2021
jsuereth
approved these changes
Oct 16, 2021
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Add markdown-toc to tooling * Remove special characters from markdown toc * Add markdown-toc CI check * Remove sudo from markdown-toc CI check * Fix merge issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
markdown-toc.