Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill out Summary metric details #2002

Merged
merged 4 commits into from
Oct 18, 2021
Merged

Fill out Summary metric details #2002

merged 4 commits into from
Oct 18, 2021

Conversation

jsuereth
Copy link
Contributor

@jsuereth jsuereth commented Oct 7, 2021

Fixes #2000

  • Add description of Summary points to data model specification. This more clearly pulls in OpenMetrics specification rather than just a link
  • Update TODO on gauge around start timestamp, as Summary needed to use similar language to match OpenMetrics.

Related open-telemetry/opentelemetry-collector-contrib#5667

@jsuereth jsuereth requested review from a team October 7, 2021 20:12
@arminru arminru added area:data-model For issues related to data model spec:metrics Related to the specification/metrics directory labels Oct 8, 2021
@jmacd jmacd mentioned this pull request Oct 12, 2021
Closed
@jmacd jmacd mentioned this pull request Oct 13, 2021
Closed
@jmacd jmacd enabled auto-merge (squash) October 18, 2021 18:28
@jmacd jmacd merged commit de30f81 into open-telemetry:main Oct 18, 2021
@pirgeo pirgeo mentioned this pull request Nov 30, 2021
Closed
6 tasks
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@jsuereth @jmacd
Fill out Summary metric details (open-telemetry#2002)
f3d30e0 
* Fix TBD on gauge start time, and fill out details of Summary metric to match Prometheus/OpenMetrics.

* Apply suggestions from code review

Co-authored-by: Joshua MacDonald <[email protected]>

* Update specification/metrics/datamodel.md

Co-authored-by: Joshua MacDonald <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirgeo pirgeo pirgeo left review comments

@jack-berg jack-berg jack-berg left review comments

@reyang reyang reyang approved these changes

@jmacd jmacd jmacd approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

Assignees

@arminru arminru

Labels
area:data-model For issues related to data model spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Summary is lacking all details in the DataModel specificaiton
8 participants
@jsuereth @carlosalberto @bogdandrutu @jmacd @reyang @jack-berg @pirgeo @arminru