Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove db.cassandra.keyspace and db.hbase.namespace, and clarify db.name #1973

Merged
merged 12 commits into from
Oct 8, 2021
Merged

Remove db.cassandra.keyspace and db.hbase.namespace, and clarify db.name #1973

merged 12 commits into from
Oct 8, 2021

Conversation

trask
Copy link
Member

@trask trask commented Sep 27, 2021

Fixes #1760

Changes

Removes db.cassandra.keyspace and db.hbase.namespace (in preference for using db.name).

Clarifies db.name in the case where a database product provides multiple concepts that could be mapped to db.name.

@trask trask requested review from a team September 27, 2021 22:37
@tigrannajaryan
Copy link
Member

Fixes #1760

Changes

Removes db.cassandra.keyspace and db.hbase.namespace (in preference for using db.name).

Clarifies db.name in the case where a database product provides multiple concepts that could be mapped to db.name.

Do we expect that the exact same value that we previously recommended to record in db.cassandra.keyspace and db.hbase.namespace to be now recorded in db.name? If that is the case then this is semantically a renaming of an attribute from schema evolution perspective and should be captured in the schema file for the next release (in the trace attributes section and any other applicable section).

@trask
Copy link
Member Author

trask commented Sep 29, 2021

Do we expect that the exact same value that we previously recommended to record in db.cassandra.keyspace and db.hbase.namespace to be now recorded in db.name? If that is the case then this is semantically a renaming of an attribute from schema evolution perspective and should be captured in the schema file for the next release

👍 schema translation added

Oberon00
Oberon00 previously requested changes Sep 29, 2021
View reviewed changes
semantic_conventions/trace/database.yaml Show resolved Hide resolved
mateuszrzeszutek
mateuszrzeszutek reviewed Sep 29, 2021
View reviewed changes
schemas/1.7.0 Outdated Show resolved Hide resolved
tigrannajaryan
tigrannajaryan approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I verified the schema file using my parser here: https://github.com/tigrannajaryan/telemetry-schema/blob/main/schema/parser_test.go

@Oberon00 Oberon00 dismissed their stale review September 30, 2021 14:11

Thanks for adding the hints back!

@trask
Copy link
Member Author

trask commented Oct 6, 2021

@open-telemetry/specs-approvers @open-telemetry/specs-trace-approvers

any additional feedback on this?

@trask
Copy link
Member Author

trask commented Oct 7, 2021

@bogdandrutu as the assignee, is there anything else you'd like to see before merging? thx!

@tigrannajaryan
Copy link
Member

This has enough approvals and I do not see any objections or unresolved comments. Merging.

@tigrannajaryan tigrannajaryan enabled auto-merge (squash) October 8, 2021 11:57
@tigrannajaryan tigrannajaryan merged commit 64c8d69 into open-telemetry:main Oct 8, 2021
ahayworth added a commit to ahayworth/opentelemetry-ruby that referenced this pull request Apr 5, 2022
@ahayworth
feat!: update for semantic conventions @ v1.10.0
4adffb1 
The most notable thing here is that the delta between 1.8.0 and 1.10.0
results in a few fields going away. This will be a breaking change for
anyone who happens to be depending upon these fields:

- `DB_CASSANDRA_KEYSPACE`
- `DB_HBASE_NAMESPACE`

Users should instead use `DB_NAME`, according to
[open-telemetry/opentelemetry-specification#1973](open-telemetry/opentelemetry-specification#1973).

Otherwise, we get the standard deal:

- A plethora of new, exciting fields!
- Reworded explanatory text!

Overall, not a terribly exciting change, but we must often take joy in
the small things, and I choose to do so here!
@ahayworth ahayworth mentioned this pull request Apr 5, 2022
Merged
fbogsany added a commit to open-telemetry/opentelemetry-ruby that referenced this pull request Apr 8, 2022
@ahayworth @fbogsany
Bump semantic_conventions gem to 1.10.0 (#1171)
159044d 
* chore: bump semconvgen from 0.4.1 -> 0.11.1

I couldn't find any huge changes from the release notes; it seems the
generated wording was improved in some cases. Regardless, let us not
drift too far behind.

* feat!: update for semantic conventions @ v1.10.0

The most notable thing here is that the delta between 1.8.0 and 1.10.0
results in a few fields going away. This will be a breaking change for
anyone who happens to be depending upon these fields:

- `DB_CASSANDRA_KEYSPACE`
- `DB_HBASE_NAMESPACE`

Users should instead use `DB_NAME`, according to
[open-telemetry/opentelemetry-specification#1973](open-telemetry/opentelemetry-specification#1973).

Otherwise, we get the standard deal:

- A plethora of new, exciting fields!
- Reworded explanatory text!

Overall, not a terribly exciting change, but we must often take joy in
the small things, and I choose to do so here!

Co-authored-by: Francis Bogsanyi <[email protected]>
MrAlias added a commit to MrAlias/opentelemetry-go-contrib that referenced this pull request Apr 25, 2022
@MrAlias
Update CassKeyspace func
d39dec2 
Use the DBNameKey instead of the removed DBCassandraKeyspaceKey. This
comes from
open-telemetry/opentelemetry-specification#1973
@MrAlias MrAlias mentioned this pull request Apr 25, 2022
Merged
2 tasks
MrAlias added a commit to open-telemetry/opentelemetry-go-contrib that referenced this pull request Apr 28, 2022
@MrAlias
Upgrade semconv to v1.10.0 (#2222)
aa8e611 
* Upgrade semconv to v1.10.0

* Update CassKeyspace func

Use the DBNameKey instead of the removed DBCassandraKeyspaceKey. This
comes from
open-telemetry/opentelemetry-specification#1973

* Add changes to changelog
@MrAlias MrAlias mentioned this pull request Apr 28, 2022
Merged
dnwe pushed a commit to dnwe/otelsarama that referenced this pull request Sep 11, 2023
@MrAlias
Upgrade semconv to v1.10.0 (#2222)
5aabc77 
* Upgrade semconv to v1.10.0

* Update CassKeyspace func

Use the DBNameKey instead of the removed DBCassandraKeyspaceKey. This
comes from
open-telemetry/opentelemetry-specification#1973

* Add changes to changelog
@trask trask mentioned this pull request Feb 8, 2024
Closed
@trask trask deleted the use-db-name-more-consistently branch October 14, 2024 21:05
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@trask
Remove db.cassandra.keyspace and db.hbase.namespace, and clarify db.n…
fedd976 
…ame (open-telemetry#1973)

Fixes open-telemetry#1760

## Changes

Removes `db.cassandra.keyspace` and `db.hbase.namespace` (in preference for using `db.name`).

Clarifies `db.name` in the case where a database product provides multiple concepts that could be mapped to `db.name`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek left review comments

@Oberon00 Oberon00 Oberon00 left review comments

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@iNikem iNikem iNikem approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@anuraaga anuraaga anuraaga approved these changes

Assignees

@bogdandrutu bogdandrutu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Propose to remove db.cassandra.keyspace and use db.name instead
8 participants
@trask @tigrannajaryan @anuraaga @carlosalberto @Oberon00 @iNikem @mateuszrzeszutek @bogdandrutu