Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add InstrumentationLibrary to Sampler.ShouldSample (#1850)" #1942

Merged
merged 2 commits into from
Sep 22, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ release.

- Prefer global user defined limits over model-sepcific default values.
([#1893](https://github.com/open-telemetry/opentelemetry-specification/pull/1893))
- Add InstrumentationLibrary to Sampler.ShouldSample.
([#1850](https://github.com/open-telemetry/opentelemetry-specification/pull/1850))

### Metrics

Expand Down
1 change: 0 additions & 1 deletion spec-compliance-matrix.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ formats is required. Implementing more than one format is optional.
| [Sampling](specification/trace/sdk.md#sampling) | | | | | | | | | | | | |
| Allow samplers to modify tracestate | | + | + | | + | + | + | | + | + | - | + |
| ShouldSample gets full parent Context | | + | + | + | + | + | + | | + | + | - | + |
| ShouldSample gets InstrumentationLibrary | | | | | | | | | | | | |
| [New Span ID created also for non-recording Spans](specification/trace/sdk.md#sdk-span-creation) | | + | + | | + | + | + | | + | + | - | + |
| [IdGenerators](specification/trace/sdk.md#id-generators) | | + | + | | + | + | | | + | + | | + |
| [SpanLimits](specification/trace/sdk.md#span-limits) | X | + | + | | + | + | | | | - | | + |
Expand Down
1 change: 0 additions & 1 deletion specification/trace/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,6 @@ Returns the sampling Decision for a `Span` to be created.
* Collection of links that will be associated with the `Span` to be created.
Typically useful for batch operations, see
[Links Between Spans](../overview.md#links-between-spans).
* `InstrumentationLibrary` (name and version) of the `Span` to be created.

Note: Implementations may "bundle" all or several arguments together in a single
object.
Expand Down