Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the Metrics API/SDK spec wording #1930

Merged
merged 3 commits into from
Sep 17, 2021
Merged

Improve the Metrics API/SDK spec wording #1930

merged 3 commits into from
Sep 17, 2021

Conversation

reyang
Copy link
Member

@reyang reyang commented Sep 16, 2021

Fixes #1918.

Fixed the wording (e.g. s/must/MUST, s/can/CAN/).
Used OpenTelemetry API authors and OpenTelemetry SDK authors wording to clarify the ownership and responsibility.

@reyang reyang requested review from a team September 16, 2021 17:54
@reyang reyang mentioned this pull request Sep 16, 2021
Closed
aabmass
aabmass approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Reiley, LGTM

@reyang reyang added area:api Cross language API specification issue area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory labels Sep 16, 2021
@reyang reyang added this to the Metrics API/SDK Feature Freeze milestone Sep 16, 2021
arminru
arminru approved these changes Sep 17, 2021
View reviewed changes
specification/metrics/api.md Show resolved Hide resolved
@arminru arminru added the editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. label Sep 17, 2021
@jmacd jmacd merged commit 02a1679 into open-telemetry:main Sep 17, 2021
@reyang reyang deleted the reyang/metrics-sdk-wording branch September 17, 2021 18:41
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@reyang @jmacd
Improve the Metrics API/SDK spec wording (open-telemetry#1930)
a600d55 
Co-authored-by: Joshua MacDonald <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacd jmacd jmacd approved these changes

@arminru arminru arminru approved these changes

@aabmass aabmass aabmass approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@jsuereth jsuereth jsuereth approved these changes

Assignees

@tigrannajaryan tigrannajaryan

Labels
area:api Cross language API specification issue area:sdk Related to the SDK editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
Metrics API/SDK Feature Freeze
Development

Successfully merging this pull request may close these issues.

Reword metrics spec to clarify what "client" means
7 participants
@reyang @jsuereth @carlosalberto @aabmass @jmacd @arminru @tigrannajaryan