Add Status to the Tracing section. #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosalberto
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
iredelmeier,
reyang,
SergeyKanzhelev,
songy23,
tedsuo and
yurishkuro
as code owners
songy23
reviewed
Jun 21, 2019
SergeyKanzhelev
approved these changes
Jun 21, 2019
|
@carlosalberto I'm not sure if you knew this and this was your intention. In GitHub the description that says "Fix, Fixes" automatically closes the issue it points to. "Addresses" doesn't. Note the underscore in the screenshots:
|
reyang
approved these changes
Jun 21, 2019
|
@SergeyKanzhelev Oh, didn't know that. Thanks, will remember it for the next time. |
|
Added a mention about we following the GRPC codes. |
songy23
approved these changes
Jun 21, 2019
tedsuo
approved these changes
Jun 21, 2019
bogdandrutu
approved these changes
Jun 21, 2019
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
* Add Status to the Tracing section. * Mention that canonical codes follow the GRPC ones.
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 21, 2024
This is a draft proposal for OpenTelemetry Logging Library SDK specification. The purpose of his proposal is to lay out the initial understanding of what Logging Library SDKs will look like. We would like to create prototypes based on this proposal in a few languages. The learnings from prototypes will then allow us to refine this proposal and eventually make the proposed approach part of the OpenTelemetry specification. The approach proposed in this OTEP is not intended to be merged into the OpenTelemetry specification after the OTEP itself is approved. We want to have successful prototypes first. This OTEP is first and foremost a specification and guidelines on how to create the prototypes. The specification defines how the OpenTelemetry Logging Library SDK exposes its functionality to authors of extensions to language-specific 3rd party logging libraries and to end users that want to produce logs in [OpenTelemetry manner](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/overview.md). The specification defines SDK elements that to some extent mirror the OpenTelemetry [Trace SDK](https://github.com/open-telemetry/opentelemetry-specification/tree/main/specification/trace). This ensures uniformity and consistency of the OpenTelemetry specification and of the implementations across traces and logs. For additional clarity the definitions in this document refer to the Trace analogs where appropriate. The descriptions of interfaces and methods in this document are intentionally very brief. Detailed and precise descriptions will be borrowed from Trace specification when this OTEP is submitted as a Log specification PR. I kept the descriptions as short as possible in this document to make reviewing it easy and fast.
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 23, 2024
This is a draft proposal for OpenTelemetry Logging Library SDK specification. The purpose of his proposal is to lay out the initial understanding of what Logging Library SDKs will look like. We would like to create prototypes based on this proposal in a few languages. The learnings from prototypes will then allow us to refine this proposal and eventually make the proposed approach part of the OpenTelemetry specification. The approach proposed in this OTEP is not intended to be merged into the OpenTelemetry specification after the OTEP itself is approved. We want to have successful prototypes first. This OTEP is first and foremost a specification and guidelines on how to create the prototypes. The specification defines how the OpenTelemetry Logging Library SDK exposes its functionality to authors of extensions to language-specific 3rd party logging libraries and to end users that want to produce logs in [OpenTelemetry manner](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/overview.md). The specification defines SDK elements that to some extent mirror the OpenTelemetry [Trace SDK](https://github.com/open-telemetry/opentelemetry-specification/tree/main/specification/trace). This ensures uniformity and consistency of the OpenTelemetry specification and of the implementations across traces and logs. For additional clarity the definitions in this document refer to the Trace analogs where appropriate. The descriptions of interfaces and methods in this document are intentionally very brief. Detailed and precise descriptions will be borrowed from Trace specification when this OTEP is submitted as a Log specification PR. I kept the descriptions as short as possible in this document to make reviewing it easy and fast.
carlosalberto
added a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Add Status to the Tracing section. * Mention that canonical codes follow the GRPC ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59
This is based on the current effort. Observe I tried to keep the canonical codes brief ;)