Clarify mutually exclusive options in span creation. #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
reyang,
SergeyKanzhelev,
tedsuo and
yurishkuro
as code owners
SergeyKanzhelev
approved these changes
Jun 17, 2019
reyang
reviewed
Jun 17, 2019
specification/tracing-api.md
Outdated
| @@ -213,6 +213,15 @@ Optional parameters (or corresponding setters on `Builder` if using a `Builder` | |||
| - The option to become a root `Span` for a new trace. | |||
| If not set, the value of [Tracer.getCurrentSpan](#getcurrentspan) at `StartSpan` | |||
| time will be used as parent. | |||
|
|
|||
| Note: The three parameters above (parent `Span`, parent `SpanContext` and `root`) are | |||
| mutually exclusive. If multiple parameters are specified or corresponding `Setter`s are | |||
There was a problem hiding this comment.
It feels like we assume there will be multiple parameters. Probably we can leave it as a language specific decision?
reyang
approved these changes
Jun 17, 2019
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
TuckTuckFloof
pushed a commit
to TuckTuckFloof/opentelemetry-specification
that referenced
this pull request
Oct 15, 2020
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 21, 2024
…en-telemetry#131) * add otlp export otep * Make SDK OTLP exporters support configurable export behavior Based on discussions from the Metrics SIG meeting, configurable export behavior from the OTLP exporter is desired to support different mertic backends * Make SDK OTLP exporters support configurable export behavior Based on discussions from the Metrics SIG meeting, configurable export behavior from the OTLP exporter is desired to support different mertic backends * fix format to pass markdownlint * add sentence to highlight cumulative -> delta is also needed Co-authored-by: Bogdan Drutu <[email protected]>
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 23, 2024
…en-telemetry#131) * add otlp export otep * Make SDK OTLP exporters support configurable export behavior Based on discussions from the Metrics SIG meeting, configurable export behavior from the OTLP exporter is desired to support different mertic backends * Make SDK OTLP exporters support configurable export behavior Based on discussions from the Metrics SIG meeting, configurable export behavior from the OTLP exporter is desired to support different mertic backends * fix format to pass markdownlint * add sentence to highlight cumulative -> delta is also needed Co-authored-by: Bogdan Drutu <[email protected]>
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the comment in #124 (comment).