Standardize TraceId/SpandId/TraceFlags field casing in log formats #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenmoto
approved these changes
Dec 10, 2020
jmacd
approved these changes
Dec 11, 2020
anuraaga
approved these changes
Dec 14, 2020
OTLP/JSON is currently using trace_id, span_id field naming. The snake case with underscores comes from Protobuf/JSON mapping rules. Elsewhere we were previously using traceid, spanid, traceflags without underscores. This changes standardizes field names to use underscores for all text log mediums where these fields may be recorded. Note: the alternate approach, i.e. keeping traceid, spanid, traceflags and renaming them in OTLP/JSON would result in OTLP/JSON format having an inconsistent naming, since all other fields use snake casing.
tigrannajaryan
force-pushed
the
feature/tigran/log-field-names
branch
from
84cb6b4
to
32915b0
Compare
kumoroku
approved these changes
Dec 14, 2020
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…pen-telemetry#1283) OTLP/JSON is currently using trace_id, span_id field naming. The snake case with underscores comes from Protobuf/JSON mapping rules. Elsewhere we were previously using traceid, spanid, traceflags without underscores. This changes standardizes field names to use underscores for all text log mediums where these fields may be recorded. Note: the alternate approach, i.e. keeping traceid, spanid, traceflags and renaming them in OTLP/JSON would result in OTLP/JSON format having an inconsistent naming, since all other fields use snake casing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTLP/JSON is currently using trace_id, span_id field naming. The snake case
with underscores comes from Protobuf/JSON mapping rules.
Elsewhere we were previously using traceid, spanid, traceflags without underscores.
This changes standardizes field names to use underscores for all text log mediums
where these fields may be recorded.
Note: the alternate approach, i.e. keeping traceid, spanid, traceflags and renaming
them in OTLP/JSON would result in OTLP/JSON format having an inconsistent naming,
since all other fields use snake casing.