-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow cloud.* ad faas.* resource attributes to be set on span #1265
Allow cloud.* ad faas.* resource attributes to be set on span #1265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Use "Note:" only for explanations, not for specifying/allowing additional things.
Co-authored-by: Christian Neumüller <[email protected]>
@open-telemetry/technical-committee @open-telemetry/specs-approvers Please take a look at this PR when you get a minute. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might consider a general statement at the resource level that any attribute that cannot be determined at startup time can be added as span attributes.
Even better might be wording that it's ok for a resource to be mutable or dynamic. I think we assume it's constant, but I think it limits some use cases for attributes (docker cgroup CPU limit?).
But this still seems like a fine step to me.
Overall good, but I'd like to get more eyes before we merge as I feel this change could be needed in other components too (I will add it to the agenda of the next SIG meeting, in case we haven't resolved this issue/PR by then). |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking merge for now, I think it would be best to discuss the feasibility of #1298 first.
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Fixes #1261
Changes
Add a note to
faas
andcloud
resource attributes that allows them to be used as span attributes in serverless functions.