Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need to maintain third party propagators. #1144

Merged
merged 6 commits into from
Nov 12, 2020

Conversation

carlosalberto
Copy link
Contributor

Initial addressing of #1047

Changes

OTel repos won't initially contain any third party propagator (such as OT or AWS). @alolita will do the related follow-up, but this is a first step to put us back in the original agreement.

@carlosalberto carlosalberto added spec:context Related to the specification/context directory area:miscellaneous For issues that don't match any other area label release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs labels Oct 26, 2020
@carlosalberto carlosalberto requested review from a team October 26, 2020 15:47
@alolita
Copy link
Member

alolita commented Oct 27, 2020

@carlosalberto I will submit a proposal by EOD tomorrow. Can you postpone removal until the maintainers have a chance to discuss?

@carlosalberto
Copy link
Contributor Author

Can you postpone removal until the maintainers have a chance to discuss?

Works, let's do that for now ;)

@github-actions
Copy link

github-actions bot commented Nov 4, 2020

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 4, 2020
specification/context/api-propagators.md Outdated Show resolved Hide resolved
@bogdandrutu
Copy link
Member

@alolita any progress? Can we merge this?

@bogdandrutu
Copy link
Member

@alolita ping

Copy link
Contributor

@NathanielRN NathanielRN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the softer wording! 😄

specification/context/api-propagators.md Outdated Show resolved Hide resolved
specification/context/api-propagators.md Outdated Show resolved Hide resolved
carlosalberto added a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
…1144)

* Remove the need to mantain third party propagators.

* Update the docs to be more liberal.

* Update specification/context/api-propagators.md

Co-authored-by: Yuri Shkuro <[email protected]>

* Update specification/context/api-propagators.md

Co-authored-by: (Eliseo) Nathaniel Ruiz Nowell <[email protected]>

* Remove the mention of XRay propagator.

Co-authored-by: Yuri Shkuro <[email protected]>
Co-authored-by: (Eliseo) Nathaniel Ruiz Nowell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:miscellaneous For issues that don't match any other area label release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:context Related to the specification/context directory Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants