-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate OTEP-83 (Introducing InstrumentationLibrary) into spec #809
Comments
There is some (limited) description: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/glossary.md#instrumentation-library |
from the spec issue triage mtg today, looks like PR #800 closes this issue |
@andrewhsu #800 solely defined the Zipkin tags for specifying the instrumentation library when exporting to Zipkin but is otherwise unrelated to this issue. This issue is asking for some prose describing what the instrumentation library defined in OTEP 83 is to be added right into the spec. |
@iNikem Is the description in the glossary mentioned above and the overview referenced there (https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/overview.md#instrumentation-libraries) sufficient or would you expect more details or better cross-references? |
This issue was requested by @SergeyKanzhelev in #800 (comment). Please ask him for more clarifications :) |
@iNikem @arminru I'd suggest to outline the required fields of the InstrumentationLibrary structure. Otherwise the conversion document we have in Zipkin and Jaeger exporter documents are referring to the name and version that was never defined as required. Moving nice pseudo-graphics explaining the concept in more details may be a bonus. |
@SergeyKanzhelev The fields are defined with the TracerProvider and MeterProvider here: |
I think this is a specific instance of #158. |
talked about this at the spec issue triage today, marking as required for ga p3, but doesn't seem like this is big blocker for ga, can bump down to release-after-ga if needed later |
There is no definition nor description of
InstrumentationLibrary
in the spec right now. OTEP-83 which introduced theInstrumentationLibrary
message was not integrated into spec.The text was updated successfully, but these errors were encountered: