Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe the span class used by Exporters #158

Closed
SergeyKanzhelev opened this issue Jun 22, 2019 · 12 comments
Closed

Describe the span class used by Exporters #158

SergeyKanzhelev opened this issue Jun 22, 2019 · 12 comments
Assignees
Labels
area:sdk Related to the SDK priority:p2 Medium priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:protocol Related to the specification/protocol directory spec:trace Related to the specification/trace directory
Milestone

Comments

@SergeyKanzhelev
Copy link
Member

Describe the class used by Exporters: how to get it's instance and it's getters/setters

@SergeyKanzhelev SergeyKanzhelev added this to the SDK proposal complete milestone Jun 22, 2019
@bogdandrutu bogdandrutu added the area:sdk Related to the SDK label Jun 26, 2019
@iredelmeier iredelmeier added the needs discussion Need more information before all suitable labels can be applied label Jul 30, 2019
@SergeyKanzhelev SergeyKanzhelev modified the milestones: SDK proposal complete, Alpha v0.2 Sep 27, 2019
@bogdandrutu bogdandrutu modified the milestones: Alpha v0.2, Alpha v0.3 Oct 10, 2019
@carlosalberto carlosalberto modified the milestones: Alpha v0.3, Alpha v0.4 Jan 28, 2020
@carlosalberto
Copy link
Contributor

Moving it to 0.4.0 for now.

@bogdandrutu bogdandrutu modified the milestones: v0.5, v0.4 Feb 18, 2020
@Oberon00
Copy link
Member

Is this about "SpanData"?

@bogdandrutu
Copy link
Member

@SergeyKanzhelev can you please revisit this issue, is it still valid?

@Oberon00
Copy link
Member

Oberon00 commented Apr 7, 2020

I think we should indeed still define, in the SDK spec, the interface between the exporter and the SpanProcessor. I.e., we pass the Span interface, as specified in the API, that only contains setters, to the SpanProcessor, right? How do we get from that to something "readable" that can be exported? The spec could be as simple as:

Language implementations must document an appropriate readable interface for Span when passing it to the exporter. Whether this is a read-only-copy, or just an extended interface for the same object instance, is up to the languages.

But IMHO we should have at least something.

@bogdandrutu bogdandrutu modified the milestones: v0.4, v0.5 Apr 28, 2020
@andrewhsu
Copy link
Member

From the SIG mtg today, sounds like this one would be suitable to be moved to the next milestone.

@carlosalberto carlosalberto modified the milestones: v0.5, v0.6 Jun 9, 2020
@bogdandrutu bogdandrutu added the spec:trace Related to the specification/trace directory label Jun 12, 2020
@bogdandrutu bogdandrutu added the spec:protocol Related to the specification/protocol directory label Jun 30, 2020
@carlosalberto
Copy link
Contributor

@Oberon00 To me it sounds like we have all the pieces now (ReadableSpan and SpanProcessor sections). Could you confirm we can close this issue? If not, please list what things remain to be done, so we can start scheduling this part.

@carlosalberto carlosalberto added the release:required-for-ga Must be resolved before GA release, or nice to have before GA label Jul 2, 2020
@Oberon00
Copy link
Member

Oberon00 commented Jul 2, 2020

@carlosalberto Indeed my #669 seems to resolve this issue. A more detailed description would be nice (e.g. is the full parent span context required or just the parent ID + isRemote), but I will add a "resolves" link in #669 (which is not merged yet, so we can't close this just yet 😃)

@bogdandrutu
Copy link
Member

Closing this because it looks resolved by #669

@Oberon00
Copy link
Member

Closing this because it looks resolved by #669

Yes, it will be auto-closed once #669 is merged 😉

@Oberon00 Oberon00 reopened this Jul 17, 2020
@Oberon00 Oberon00 removed the needs discussion Need more information before all suitable labels can be applied label Jul 17, 2020
@Oberon00
Copy link
Member

As pointed out in #669 (comment), after #669 we still have to specify some details on the SpanData/proto.Span/ReadableSpan class, like that resources should be accessible, whether the full parent SpanContext should be accessible (cf. #366), etc.

@reyang reyang added the priority:p2 Medium priority level label Jul 24, 2020
@andrewhsu andrewhsu added release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs and removed release:required-for-ga Must be resolved before GA release, or nice to have before GA labels Sep 25, 2020
@andrewhsu
Copy link
Member

from the issue triage mtg today with TC, allowing changes related to this issue for GA if editorial changes only

@Oberon00 Oberon00 changed the title Describe proto.Span class Describe the span class used by Exporters Oct 14, 2020
@Oberon00
Copy link
Member

Oberon00 commented Apr 7, 2021

I think this was fully resolved with #756. Please reopen if you still see open points.

@Oberon00 Oberon00 closed this as completed Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK priority:p2 Medium priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:protocol Related to the specification/protocol directory spec:trace Related to the specification/trace directory
Projects
None yet
Development

No branches or pull requests

7 participants