-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc-trace-bin support for gRPC trace? #639
Comments
This requires #437 "Update Binary format in the Specification" (since #426 removed it; it was there before but was "temporarily" removed due to a larger refactoring of both in-process and cross-process context propagation via open-telemetry/oteps#66). However, #437 depends on #577 "Small clean up for Propagators" which turned out to be not so small (has been in review for over a month now). |
While Opinion on this @bogdandrutu ? |
How will grpc-trace-bin work?
I'd like to understand the motivation here because there is no detail or discussion. |
grpc-trace-bin is the binary equivalent of the traceparent. They transmit the same data.
it is required for compatibility with opencensus (at least in js) because that is what OC used.
the motivation is simply that gRPC is a binary protocol which can take advantage of the more tightly packed binary format to save some bytes on each request |
I think we also need to have a separate discussion with gRPC to deprecate grpc-trace-bin and switch them to the TraceContext header. |
Is this still in development? I'm trying to enable distributed tracing from a JS service to a Golang service which communicate via gRPC but it doesn't work as described on @opentelemetry/instrumentation-grpc, could |
Also an interested party here |
In Java gRPC Instrumentation, we don't have any special handling for this, which means we (only) use the |
Is this related to #437? |
Looks like current spec describes only W3C traceparent header for span context propagation for now.
However, Opencensus gRPC spec uses
grpc-trace-bin
header for spancontext propagation.Does open-telemetry have a plan to support it?
The text was updated successfully, but these errors were encountered: