Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-trace-bin header support #37

Open
xd009642 opened this issue Jun 10, 2020 · 6 comments
Open

grpc-trace-bin header support #37

xd009642 opened this issue Jun 10, 2020 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@xd009642
Copy link
Contributor

As well as traceparent for context propagation there's also grpc-trace-bin and x-cloud-trace-context, my current work system is using grpc-trace-bin so it would be nice if it was as easy to propagate the traces as it was with traceparent or the b3 headers

@jtescher
Copy link
Member

jtescher commented Jul 2, 2020

The spec discussion for this is currently happening in open-telemetry/opentelemetry-specification#639

@hdost
Copy link
Contributor

hdost commented Apr 12, 2023

There's no reason this could not be implemented as an extension crate, it doesn't need to be built into the rust sdk/api.

@hdost hdost added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Feb 21, 2024
@hdost
Copy link
Contributor

hdost commented Feb 21, 2024

So i think while this would provide some compatibility with open census, this doesn't seem like it will be in the root. We split the repos recently. I think we can transfer this to the contrib repo. Spec https://graphql-faas.github.io/opencensus-specs/trace/gRPC.html if anyone wants to implement.

@hdost hdost transferred this issue from open-telemetry/opentelemetry-rust Feb 22, 2024
@RichardChukwu
Copy link
Contributor

Hi @xd009642 @hdost Is this being actively worked on at the moment please?

@xd009642
Copy link
Contributor Author

No, but I'm also not sure if it's relevant anymore? It might have gotten in elsewhere and this issue just not been cleaned up

@RichardChukwu
Copy link
Contributor

Ok. How do we confirm that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants