Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid hash ID in path logs/data-model/#event-name #4338

Closed
chalin opened this issue Dec 13, 2024 · 2 comments · Fixed by #4340
Closed

Invalid hash ID in path logs/data-model/#event-name #4338

chalin opened this issue Dec 13, 2024 · 2 comments · Fixed by #4340

Comments

@chalin
Copy link
Contributor

chalin commented Dec 13, 2024 •
edited
Loading

Originally posted by @chalin in #4320 (review):

This PR has breaking changes, w.r.t. link checking, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/12313997571/job/34369378422?pr=5782. ...

Hash ID #event-name is invalid. It should be #field-eventname.
@chalin chalin mentioned this issue Dec 13, 2024
Open
@chalin
Copy link
Contributor Author

chalin commented Dec 13, 2024

As I mention in

running https://github.com/open-telemetry/opentelemetry.io/actions/workflows/build-dev.yml would have caught this error earlier, e.g.: https://github.com/open-telemetry/opentelemetry.io/actions/runs/12314358967/job/34370536380

/cc @open-telemetry/docs-maintainers

@chalin chalin changed the title Invalid hash ID in logs/data-model/#event-name Invalid hash ID in path logs/data-model/#event-name Dec 13, 2024
@chalin
Copy link
Contributor Author

chalin commented Dec 13, 2024

FYI, this has been patched on the OTel-website side: see scripts/content-modules/adjust-pages.pl in https://github.com/open-telemetry/opentelemetry.io/pull/5782/files.

@chalin chalin mentioned this issue Dec 13, 2024
Merged
@lmolkova lmolkova mentioned this issue Dec 13, 2024
Merged
@trask trask mentioned this issue Dec 13, 2024
Merged
lmolkova added a commit that referenced this issue Dec 17, 2024
@lmolkova
Update release procedure in contributing.md (#4339)
e81d06b 
1. Remove schemas updates - it's now in semantic-conventions
2. Remove manual step to update opentelemetry.io - it's automated
3. Add manual check for broken link anchors (see
open-telemetry/semantic-conventions#1009,
#4338 for the context)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix links trask/opentelemetry-specification
1 participant
@chalin