-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define whether instrumentations can emit non-event log records #4234
Comments
To add a bit of context: client libraries or infra components usually emit some logs using some non-OTel logging API. While it's unlikely that existing libraries will replace their existing logging with OTel one, by providing user-facing logging API we allow future native instrumentations that use OTel for metrics and tracing to also use OTel logging API instead of adding a new dependency. Before #4225 it was not possible. |
This actually seems to be two separate questions/issues -
In the first case, I think it is non-controversial to suggest that instrumentation libraries must only rely on OpenTelemetry APIs. I will eschew commentary on the second case for now. |
Logs SIG meeting notes: |
To add to @austinlparker comment #4234 (comment) - from native instrumentation perspective I'm mostly interested in the case 3:
|
@lmolkova I considered adding that use case to the comment but left it off deliberately in order to keep the discussion focused. I do agree with you, though, it is an important use case to consider. |
One of OTel Go prototypes for adding support for events makes emitting non-event log records "natural": open-telemetry/opentelemetry-go#6018 |
Imagine I'm instrumenting kafka:
The library logs are emitted with is not relevant to users - they'd get the same logs if lib used 3rd party logger or OTel API. So I don't see why we should limit instrumentations from using OTel API to emit undocumented regular (but structured) logs.
Originally posted by @lmolkova in #4225 (comment)
The text was updated successfully, but these errors were encountered: