Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize Metrics Instrument Enabled #4215

Open
codeboten opened this issue Sep 18, 2024 · 10 comments
Open

Stabilize Metrics Instrument Enabled #4215

codeboten opened this issue Sep 18, 2024 · 10 comments
Assignees
@pellared
Labels
spec:metrics Related to the specification/metrics directory triage:accepted:ready-with-sponsor Ready to be implemented and has a specification sponsor assigned

Comments

@codeboten
Copy link
Contributor

I believe the last issue around stabilizing the Enabled API for metric instruments was #4211 and it is now merge.

Are there other issues preventing this from stabilizing?
@codeboten codeboten added the spec:metrics Related to the specification/metrics directory label Sep 18, 2024
@sfc-gh-bdrutu
Copy link

I support this.

@jack-berg
Copy link
Member

Do we meet the requirement for prototype implementations?

Java has a prototype. What other languages have prototypes?

@codeboten
Copy link
Contributor Author

Go has a prototype in this PR open-telemetry/opentelemetry-go#5768

codeboten added a commit to codeboten/opentelemetry-specification that referenced this issue Sep 19, 2024
@codeboten
Mark Enabled API for synchronous instruments stable
79af5d1 
This marks the API stable.

Fixes open-telemetry#4215

Signed-off-by: Alex Boten <[email protected]>
@codeboten
Copy link
Contributor Author

@cijothomas pointed out that .net already supports this API https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.metrics.instrument.enabled?view=net-8.0

@codeboten codeboten mentioned this issue Sep 19, 2024
Closed
4 tasks
@svrnm svrnm added the triage:deciding:community-feedback Open to community discussion. If the community can provide sufficient reasoning, it may be accepted label Sep 30, 2024
@svrnm
Copy link
Member

svrnm commented Sep 30, 2024

how many prototypes do we need?

@reyang
Copy link
Member

reyang commented Oct 9, 2024

how many prototypes do we need?

Three.

@jack-berg
Copy link
Member

Go has a prototype in this PR open-telemetry/opentelemetry-go#5768

Discussed in the 10/9/2024 TC meeting. A PR doesn't count as a prototype. For user facing APIs, part of the point of prototyping is to get in the hands of users to solicit feedback / issues, and a PR doesn't accomplish this goal. Several languages have invested in tooling to be able to differentiate between experimental and stable APIs. We recommend that languages develop this tooling. Now that the spec has stable traces, metrics, and logs, the continued evolution of these signals is dependent on prototyping and tooling to publish prototypes separately from stable APIs.

@pellared
Copy link
Member

I created a blocking issue:

@github-actions github-actions bot added the triage:followup Needs follow up during triage label Oct 15, 2024
@pellared pellared mentioned this issue Oct 15, 2024
Closed
@trask trask removed the triage:followup Needs follow up during triage label Oct 15, 2024
@mx-psi
Copy link
Member

mx-psi commented Nov 19, 2024

Discussed in the 2024-11-19 meeting.

This is blocked by #4256, for which we decided to wait for two weeks per #4256 (comment).

The blocker on prototypes mentioned on #4215 (comment) is being relaxed by #4286. I think it makes sense to apply a more lenient approach here since this is a very simple addition to the API and we have some prototyping.

@github-actions github-actions bot added the triage:followup Needs follow up during triage label Nov 20, 2024
@svrnm svrnm added triage:accepted:ready-with-sponsor Ready to be implemented and has a specification sponsor assigned and removed triage:deciding:community-feedback Open to community discussion. If the community can provide sufficient reasoning, it may be accepted triage:followup Needs follow up during triage labels Nov 25, 2024
@mx-psi mx-psi mentioned this issue Nov 25, 2024
Closed
@pellared
Copy link
Member

We plan to add experimental support for Metrics Instrument Enabled in OTel Go SDK:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pellared pellared

Labels
spec:metrics Related to the specification/metrics directory triage:accepted:ready-with-sponsor Ready to be implemented and has a specification sponsor assigned
Projects
🔭 Main Backlog
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark Enabled API for synchronous instruments stable codeboten/opentelemetry-specification
8 participants
@trask @codeboten @svrnm @pellared @mx-psi @reyang @jack-berg @sfc-gh-bdrutu