Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specs for proxy support in exporters #4007

Open
ecourreges-orange opened this issue Apr 23, 2024 · 5 comments
Open

Add specs for proxy support in exporters #4007

ecourreges-orange opened this issue Apr 23, 2024 · 5 comments
Labels
area:configuration Related to configuring the SDK sig-issue A specific SIG should look into this before discussing at the spec spec:protocol Related to the specification/protocol directory

Comments

@ecourreges-orange
Copy link
Contributor

What are you trying to achieve?

Specs of Environment Variables needs to be added here, following added support for exporting via proxies in java and in the collector

Then PRs and implementation need to be added to the java and/or java-instrumentation and in the collector.

What did you expect to see?
Some proxy environment variables corresponding to the functionalities that were coded in February or March 2024.
So that they can be used without code in java and without digging too much.

@ecourreges-orange ecourreges-orange added the spec:protocol Related to the specification/protocol directory label Apr 23, 2024
@arminru arminru added the area:configuration Related to configuring the SDK label Apr 23, 2024
@jack-berg
Copy link
Member

Now that file configuration has enough pieces to build prototypes, its time to reevaluate the environment variable moratoirum, and make a choice about the future of environment variables:

Do we put a pause on future environment variables and instead only add new configurable surface area to file configuration? This incentivizes implementations of file configuration, but obviously makes things more difficult for languages which are lagging behind, and for users which aren't ready to adopt experimental features.

@austinlparker austinlparker added the triage:deciding:needs-info Not enough information. It is left open to provide the author with time to add more details label Apr 23, 2024
@austinlparker
Copy link
Member

Question -- Is the ask here that the OTLP Exporter spec be extended to codify proxy options (potentially as SHOULD rather than MUST) and then add config support?

@ecourreges-orange
Copy link
Contributor Author

Question -- Is the ask here that the OTLP Exporter spec be extended to codify proxy options (potentially as SHOULD rather than MUST) and then add config support?

Yes this exactly the intent of my demand. I can submit a PR for the specs if this would help (although probably not within 3 weeks because of vacations).

@trask trask added sig-issue A specific SIG should look into this before discussing at the spec and removed triage:deciding:needs-info Not enough information. It is left open to provide the author with time to add more details labels Jul 16, 2024
@krismarc
Copy link

Hey, do we have any update on this? Seems like java exporter doesn't honor -DnonProxyHosts and yet causes exporter to use proxy while it shouldn't if endpoint is whitelited. open-telemetry/opentelemetry-java-instrumentation#12240 (comment)

@trask
Copy link
Member

trask commented Oct 16, 2024

@krismarc do I understand from open-telemetry/opentelemetry-java-instrumentation#12240 (comment) that issue is resolved? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:configuration Related to configuring the SDK sig-issue A specific SIG should look into this before discussing at the spec spec:protocol Related to the specification/protocol directory
Projects
Status: Not blocking stability
Development

No branches or pull requests

6 participants