-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support proxy configuration field in all exporters #5761
Comments
@jpkrohling saw your LI post. Would love to work on this with help of your guidance if it's still available 🙌 |
Absolutely, ping me on Slack, and I can help you further. But basically, I believe it's just a matter of adding a new config option here:
And then add the proxy URL to the transport around here: You can probably set the Proxy attribute of the transport to this: |
Hey @jpkrohling, I’m interested in this issue. If it has been solved by @hrittikhere thats great 😊. I’m also looking for some good first issues, if you have any recommendations. |
We do have other good first issues in this repository:
good first issue
Feel free to choose one. |
**Description:** Adding a feature to support proxy configuration field in all exporters **Link to tracking Issue:** #5761 --------- Signed-off-by: Hrittik Roy <[email protected]> Signed-off-by: Juraci Paixão Kröhling <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]> Co-authored-by: Andrzej Stencel <[email protected]> Co-authored-by: Alex Boten <[email protected]>
We can close this as fixed @jpkrohling 👀 |
**Description:** Adding a feature to support proxy configuration field in all exporters **Link to tracking Issue:** open-telemetry#5761 --------- Signed-off-by: Hrittik Roy <[email protected]> Signed-off-by: Juraci Paixão Kröhling <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]> Co-authored-by: Andrzej Stencel <[email protected]> Co-authored-by: Alex Boten <[email protected]>
Hi, It seems there is no documentation about this setting usage |
@loicdescotte, would you mind opening a PR, and perhaps another issue? Basically, one can set |
Hi, I can't open a PR as I won't be able to test it, because I am using AWS Distro for OTEL, that is not using the same semantics for the proxy. I can't open an issue though. |
Is your feature request related to a problem? Please describe.
We have collectors running in hosts within internal network which does not allow outgoing traffic to backends in public internet. A proxy must be used. However, currently OpenTelemetry collector only supports setting a proxy through HTTP[S]_PROXY environment variable, which is extremely unfriendly for collectors running in physical hosts. Only SREs have the privilege to start/stop/restart collectors and it's very hard to inject environment variables to these processes.
Describe the solution you'd like
I would like to field of configuration that can be explicitly set such as:
The config can be added to places like https://github.com/open-telemetry/opentelemetry-collector/tree/main/exporter/exporterhelper
Each exporter should be able have a separate proxy config and should override proxies set by environment variables.
Describe alternatives you've considered
No alternative.
Additional context
Some exporters already support proxy, such as awsxray exporter.
The text was updated successfully, but these errors were encountered: