Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of env expansion with non-standard integer notation #3959

Closed
Tracked by #3963
mx-psi opened this issue Mar 25, 2024 · 2 comments
Closed
Tracked by #3963

Add example of env expansion with non-standard integer notation #3959

mx-psi opened this issue Mar 25, 2024 · 2 comments
Labels
area:configuration Related to configuring the SDK triage:accepted:ready Ready to be implemented. Small enough or uncontroversial enough to be implemented without sponsor

Comments

@mx-psi
Copy link
Member

mx-psi commented Mar 25, 2024

Consider the case where the variable HEX_VALUE is set to 0xdeadbeef, and a configuration field such as:

string_field: ${HEX_VALUE}

where string_field has type string on the JSON schema. What should its value be? I am not sure which of the following would be correct per the spec:

  1. The string with value 0xdeadbeef (preserving the original presentation format)
  2. The string 3735928559 (representing with a standard base 10 format)
  3. A type validation error

Having an explicit example of this case on the spec would be useful to understand it.

@jack-berg jack-berg transferred this issue from open-telemetry/opentelemetry-configuration Mar 25, 2024
@jack-berg jack-berg added the area:configuration Related to configuring the SDK label Mar 25, 2024
@trask trask added triage:deciding:community-feedback Open to community discussion. If the community can provide sufficient reasoning, it may be accepted triage:accepted:ready Ready to be implemented. Small enough or uncontroversial enough to be implemented without sponsor and removed triage:deciding:community-feedback Open to community discussion. If the community can provide sufficient reasoning, it may be accepted labels Mar 26, 2024
@trask
Copy link
Member

trask commented Mar 26, 2024

cc @open-telemetry/configuration-maintainers

@austinlparker austinlparker moved this to Spec Icebox in 🔭 Main Backlog Apr 16, 2024
jack-berg pushed a commit that referenced this issue May 8, 2024
Updates #3959

## Changes

Adds example for using an integer in hexadecimal notation. The intention
is to show the difference when quoting vs not quoting and make explicit
that quoting means keeping the original representation (we already have
the `true` example but this one has two different representations).

I think this is already implied by the text so this is only a change in
the example.

* [x] Related issues #3959, part of #3963

---------

Co-authored-by: Robert Pająk <[email protected]>
@mx-psi
Copy link
Member Author

mx-psi commented May 9, 2024

Fixed by #3975

@mx-psi mx-psi closed this as completed May 9, 2024
@github-project-automation github-project-automation bot moved this from Spec - Accepted to Completed Projects in 🔭 Main Backlog May 9, 2024
@danielgblanco danielgblanco moved this from Completed Projects to Spec - Closed in 🔭 Main Backlog Jul 29, 2024
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 31, 2024
…y#3975)

Updates open-telemetry#3959

## Changes

Adds example for using an integer in hexadecimal notation. The intention
is to show the difference when quoting vs not quoting and make explicit
that quoting means keeping the original representation (we already have
the `true` example but this one has two different representations).

I think this is already implied by the text so this is only a change in
the example.

* [x] Related issues open-telemetry#3959, part of open-telemetry#3963

---------

Co-authored-by: Robert Pająk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:configuration Related to configuring the SDK triage:accepted:ready Ready to be implemented. Small enough or uncontroversial enough to be implemented without sponsor
Projects
Status: Spec - Closed
Development

No branches or pull requests

4 participants