Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTLP exporter retry] Fix and further clarify the definition of "transient error" #3652

Closed
alanwest opened this issue Aug 10, 2023 · 0 comments · Fixed by #3653
Closed

[OTLP exporter retry] Fix and further clarify the definition of "transient error" #3652

alanwest opened this issue Aug 10, 2023 · 0 comments · Fixed by #3653
Assignees
Labels
spec:protocol Related to the specification/protocol directory

Comments

@alanwest
Copy link
Member

Related to #3639

Transient errors are not correctly nor completely defined in the OTLP exporter spec.

As discussed in this week's SIG meeting the following statement is apparently out-of-date and should be considered a bug. The status codes referenced in this statement do not align with the set of retryable HTTP status codes in the protocol specification.

For OTLP/HTTP, the errors 408 (Request Timeout) and 5xx (Server Errors) are defined as transient

In addition to addressing this bug, I believe it would be valuable to more clearly define transient error in the exporter spec to avoid the need to comb over the protocol specification to try and deduce the definition.

@alanwest alanwest added the spec:protocol Related to the specification/protocol directory label Aug 10, 2023
carlosalberto pushed a commit that referenced this issue Sep 7, 2023
Fixes #3652

This PR attempts to clearly define `transient error` in the OTLP
exporter specification.

It also fixes a bug in that the set of retryable status codes in the
OTLP exporter spec vs. the protocol spec are not aligned.
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 31, 2024
…#3653)

Fixes open-telemetry#3652

This PR attempts to clearly define `transient error` in the OTLP
exporter specification.

It also fixes a bug in that the set of retryable status codes in the
OTLP exporter spec vs. the protocol spec are not aligned.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:protocol Related to the specification/protocol directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants