Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous additional semantic convention attribute names #362

Closed
kbrockhoff opened this issue Nov 21, 2019 · 2 comments
Closed

Miscellaneous additional semantic convention attribute names #362

kbrockhoff opened this issue Nov 21, 2019 · 2 comments
Labels
area:semantic-conventions Related to semantic conventions release:after-ga Not required before GA release, and not going to work on before GA

Comments

@kbrockhoff
Copy link
Member

As I am working on various implementations I have found a number attribute names that are not currently specified or have an existing open issue.

http.user_agent - present in OpenCensus, absolutely required by systems my team is currently working on

iam.user - username value from basic authentication or subject from access/identity token, absolutely required by systems my team is currently working on

iam.role - scope/authorities from access token, not needed by my team but useful for completeness of the specification

message_bus.destination - present in OpenTracing, absolutely required by systems my team is currently working on

Also needed is more standardization of "component" attribute values. This already a issue to standardize on db for database spans. Other needs we have found are:

messaging - asynchronous messaging systems
rpc - instead of grpc or if grpc is kept then also needed is rmi, thrift, etc.
cluster - or maybe streaming for internal cross node communications on streaming platforms

@jmacd
Copy link
Contributor

jmacd commented Nov 25, 2019

I agree about the four suggested labels. As for the component question, see #336. I feel that component is not well defined (or needed). OTOH, I'd like to specify a standard attribute for the name and version supplied to named tracers and meters.

@SergeyKanzhelev SergeyKanzhelev added the area:semantic-conventions Related to semantic conventions label Dec 4, 2019
SergeyKanzhelev added a commit to kbrockhoff/opentelemetry-specification that referenced this issue Dec 20, 2019
bogdandrutu added a commit to kbrockhoff/opentelemetry-specification that referenced this issue Dec 25, 2019
kbrockhoff added a commit to kbrockhoff/opentelemetry-specification that referenced this issue Dec 26, 2019
kbrockhoff added a commit to kbrockhoff/opentelemetry-specification that referenced this issue Dec 26, 2019
…github.com:kbrockhoff/opentelemetry-specification into additional-http-sem-conventions-open-telemetry#362
kbrockhoff added a commit to kbrockhoff/opentelemetry-specification that referenced this issue Dec 26, 2019
kbrockhoff added a commit to kbrockhoff/opentelemetry-specification that referenced this issue Dec 26, 2019
… of github.com:kbrockhoff/opentelemetry-specification into additional-resource-sem-conventions-open-telemetry#362
kbrockhoff added a commit to kbrockhoff/opentelemetry-specification that referenced this issue Dec 26, 2019
kbrockhoff added a commit to kbrockhoff/opentelemetry-specification that referenced this issue Dec 26, 2019
kbrockhoff added a commit to kbrockhoff/opentelemetry-specification that referenced this issue Dec 26, 2019
yurishkuro added a commit to kbrockhoff/opentelemetry-specification that referenced this issue Jan 6, 2020
SergeyKanzhelev added a commit to kbrockhoff/opentelemetry-specification that referenced this issue Jan 7, 2020
bogdandrutu added a commit to kbrockhoff/opentelemetry-specification that referenced this issue Jan 16, 2020
bogdandrutu added a commit to kbrockhoff/opentelemetry-specification that referenced this issue Jan 16, 2020
kbrockhoff added a commit to kbrockhoff/opentelemetry-specification that referenced this issue Jan 17, 2020
kbrockhoff added a commit to kbrockhoff/opentelemetry-specification that referenced this issue Jan 17, 2020
kbrockhoff added a commit to kbrockhoff/opentelemetry-specification that referenced this issue Jan 23, 2020
@reyang reyang added the release:after-ga Not required before GA release, and not going to work on before GA label Jul 6, 2020
@kbrockhoff
Copy link
Member Author

All these items have been addressed by other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions release:after-ga Not required before GA release, and not going to work on before GA
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants