-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow resources as span attributes #274
Comments
Please clarify what an "Application" is. Is that a "http.route"? |
See my new comments: #263 (comment) |
Some clarifications (from #263 (comment)):
|
Hey @Oberon00 what's the state of this? can we close it? If not, what remains to be done? |
Well, #421 and open-telemetry/oteps#66 could both be helpful when designing a solution, but nothing has been done explicitly to solve this issue and the initial description still applies. I think of this primarily as a potential solution to #335, which I would still love to be solved. |
Related proposal: open-telemetry/oteps#78 |
Moving this to the next milestone. |
This sounds more like having complex values for attributes and not necessarily resources? I like @jmacd's otep. For a simpler approach I was going to propose being able to attach a Resource to either the context or named tracer. |
@tsloughter Why complex values? This is only about not needing to send the data for each Span but only once per batch (or less). |
@Oberon00 ah, didn't consider batching since it would be on individual spans. Now I get it why it is more than just key/value pairs for the value of an attribute. I'd like something like this, or jmacd's otep (or just tie the resource to a context so all spans in that context use it). My use is processes in Erlang nodes that are long lived and can represent their own "service". So would want to have spans created in that process have a resource with |
See #263 (comment).
For some types of spans (e.g. HTTP server) there is potentially a lot of information that can be different from span to span, but there is only a low number of combinations for each process. For example, it would make sense to have
http.app_info
attribute the value of which is a resource that contains information such as an application root, server name, application name, server port (see linked PR).The text was updated successfully, but these errors were encountered: