Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Cloud Logging specification: log_name should not map to Name #1808

Closed
jsuereth opened this issue Jul 8, 2021 · 1 comment · Fixed by #2092
Closed

Google Cloud Logging specification: log_name should not map to Name #1808

jsuereth opened this issue Jul 8, 2021 · 1 comment · Fixed by #2092
Assignees
Labels
spec:logs Related to the specification/logs directory

Comments

@jsuereth
Copy link
Contributor

jsuereth commented Jul 8, 2021

What are you trying to achieve?

According to the logging data model: Name: Short event identifier., and additionally in the Google Cloud mapping, Name is set to log_name, which is documented here.

TL;DR; log_name in cloud represents more of a "source file" of the log and not an event identifier. It has values like:

"projects/[PROJECT_ID]/logs/[LOG_ID]"
"organizations/[ORGANIZATION_ID]/logs/[LOG_ID]"
"billingAccounts/[BILLING_ACCOUNT_ID]/logs/[LOG_ID]"
"folders/[FOLDER_ID]/logs/[LOG_ID]"

Which does not seem to be in the spirit of the logging data model.

Proposal

We should move log_name to either an Attribute or Resource.Attribute in the logging data model.

@jsuereth jsuereth added the spec:logs Related to the specification/logs directory label Jul 8, 2021
@tigrannajaryan tigrannajaryan added the help wanted Extra attention is needed label Oct 13, 2021
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-specification that referenced this issue Nov 2, 2021
Fixes open-telemetry#1808

The log_name should not map to Name, they are not the same thing.

log_name description: The resource name of the log to which this log entry belongs.
(See https://cloud.google.com/logging/docs/reference/v2/rpc/google.logging.v2#logentry)

Name description: Short event identifier that does not contain varying parts.

log_name is now mapped to a Google-specific attribute. If better mapping is known
I can change to that but I don't see anything else in log data model log_name maps
nicely to.
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-specification that referenced this issue Nov 2, 2021
Fixes open-telemetry#1808

The log_name should not map to Name, they are not the same thing.

log_name description: The resource name of the log to which this log entry belongs.
(See https://cloud.google.com/logging/docs/reference/v2/rpc/google.logging.v2#logentry)

Name description: Short event identifier that does not contain varying parts.

log_name is now mapped to a Google-specific attribute. If better mapping is known
I can change to that but I don't see anything else in log data model log_name maps
nicely to.
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-specification that referenced this issue Nov 2, 2021
Fixes open-telemetry#1808

The log_name should not map to Name, they are not the same thing.

log_name description: The resource name of the log to which this log entry belongs.
(See https://cloud.google.com/logging/docs/reference/v2/rpc/google.logging.v2#logentry)

Name description: Short event identifier that does not contain varying parts.

log_name is now mapped to a Google-specific attribute. If better mapping is known
I can change to that but I don't see anything else in log data model log_name maps
nicely to.
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-specification that referenced this issue Nov 2, 2021
Fixes open-telemetry#1808

The log_name should not map to Name, they are not the same thing.

log_name description: The resource name of the log to which this log entry belongs.
(See https://cloud.google.com/logging/docs/reference/v2/rpc/google.logging.v2#logentry)

Name description: Short event identifier that does not contain varying parts.

log_name is now mapped to a Google-specific attribute. If better mapping is known
I can change to that but I don't see anything else in log data model log_name maps
nicely to.
@tigrannajaryan tigrannajaryan self-assigned this Nov 2, 2021
@tigrannajaryan tigrannajaryan added release:required-logdatamodel-ga Required for declaring log data model stable and removed help wanted Extra attention is needed labels Nov 2, 2021
@djaglowski
Copy link
Member

This was discussed today in the Log SIG as part of our effort to resolve any issues that may affect the log data model. PR #2092 potentially resolves the issue, pending review from @jsuereth.

@tigrannajaryan tigrannajaryan removed the release:required-logdatamodel-ga Required for declaring log data model stable label Dec 1, 2021
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-specification that referenced this issue Dec 10, 2021
Fixes open-telemetry#1808

The log_name should not map to Name, they are not the same thing.

log_name description: The resource name of the log to which this log entry belongs.
(See https://cloud.google.com/logging/docs/reference/v2/rpc/google.logging.v2#logentry)

Name description: Short event identifier that does not contain varying parts.

log_name is now mapped to a Google-specific attribute. If better mapping is known
I can change to that but I don't see anything else in log data model log_name maps
nicely to.
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-specification that referenced this issue Dec 10, 2021
Fixes open-telemetry#1808

The log_name should not map to Name, they are not the same thing.

log_name description: The resource name of the log to which this log entry belongs.
(See https://cloud.google.com/logging/docs/reference/v2/rpc/google.logging.v2#logentry)

Name description: Short event identifier that does not contain varying parts.

log_name is now mapped to a Google-specific attribute. If better mapping is known
I can change to that but I don't see anything else in log data model log_name maps
nicely to.
jmacd pushed a commit that referenced this issue Dec 10, 2021
Fixes #1808

The log_name should not map to Name, they are not the same thing.

log_name description: The resource name of the log to which this log entry belongs.
(See https://cloud.google.com/logging/docs/reference/v2/rpc/google.logging.v2#logentry)

Name description: Short event identifier that does not contain varying parts.

log_name is now mapped to a Google-specific attribute. If better mapping is known
I can change to that but I don't see anything else in log data model log_name maps
nicely to.
joaopgrassi pushed a commit to dynatrace-oss-contrib/semantic-conventions that referenced this issue Mar 21, 2024
Fixes open-telemetry/opentelemetry-specification#1808

The log_name should not map to Name, they are not the same thing.

log_name description: The resource name of the log to which this log entry belongs.
(See https://cloud.google.com/logging/docs/reference/v2/rpc/google.logging.v2#logentry)

Name description: Short event identifier that does not contain varying parts.

log_name is now mapped to a Google-specific attribute. If better mapping is known
I can change to that but I don't see anything else in log data model log_name maps
nicely to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:logs Related to the specification/logs directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants