Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface of binary injector depends on whether we will have a single of two fields for trace context #11

Closed
SergeyKanzhelev opened this issue Apr 22, 2019 · 6 comments
Labels
spec:context Related to the specification/context directory
Milestone

Comments

@SergeyKanzhelev
Copy link
Member

Current implementation of binary context inject/extract expects that entire SpanContext can be encoded in a single field:

https://github.com/bogdandrutu/openconsensus/blob/42f90bf8196cc1e3913510160cdfdc3995a7119d/api/src/main/java/openconsensus/context/propagation/BinaryFormat.java#L26-L33

However current proposal lists traceparent and tracestate as separate headers. See w3c/trace-context-binary#7 with the proposal to change it

@yurishkuro
Copy link
Member

I am in favor of a single binary blob for trace context in w3c

@carlosalberto
Copy link
Contributor

I'm in favor of a single binary blob as well.

@SergeyKanzhelev
Copy link
Member Author

@carlosalberto please comment on issue in W3C on benefits of a single blob over two blobs.

@bogdandrutu bogdandrutu transferred this issue from open-telemetry/opentelemetry-java May 13, 2019
@SergeyKanzhelev SergeyKanzhelev modified the milestones: API complete, API proposal done, API revision: 07-2019 Jun 3, 2019
@iredelmeier iredelmeier added the spec:context Related to the specification/context directory label Jul 30, 2019
@SergeyKanzhelev SergeyKanzhelev modified the milestones: API revision: 07-2019, Alpha v0.3 Sep 27, 2019
@tedsuo
Copy link
Contributor

tedsuo commented Dec 4, 2019

Since it has been resolved ghat we are going to follow https://github.com/w3c/trace-context-binary for our own interface, I am closing this issue for now.

@SergeyKanzhelev
Copy link
Member Author

the issue is still there. Current spec expect that formatter can format context into a single bytes blob where spec is written for multiple fields.

@jmacd jmacd modified the milestones: Alpha v0.3, Alpha v0.4 Jan 29, 2020
@jmacd
Copy link
Contributor

jmacd commented Jan 29, 2020

This is covered in #426, which raises several points about the need for more specification about binary propagation. These will be addressed in the next milestone.

@jmacd jmacd closed this as completed Jan 29, 2020
@bogdandrutu bogdandrutu modified the milestones: v0.5, v0.4 May 12, 2020
TuckTuckFloof pushed a commit to TuckTuckFloof/opentelemetry-specification that referenced this issue Oct 15, 2020
…clang-format (open-telemetry#11)

* Build env setup scripts

* Remove sqlite for now

* Reduce the scope of .clang-format .gitattributes and .gitignore changes

* Fix code comment
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 21, 2024
* Document global initializion

* Global initializer requirements

* Minor revision

* Set status

* Rename 0010-global-init.md to text/0005-global-init.md

* OTr->OTel
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 23, 2024
* Document global initializion

* Global initializer requirements

* Minor revision

* Set status

* Rename 0010-global-init.md to text/0005-global-init.md

* OTr->OTel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:context Related to the specification/context directory
Projects
None yet
Development

No branches or pull requests

7 participants