-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interface of binary injector depends on whether we will have a single of two fields for trace context #11
Comments
I am in favor of a single binary blob for trace context in w3c |
I'm in favor of a single binary blob as well. |
@carlosalberto please comment on issue in W3C on benefits of a single blob over two blobs. |
Since it has been resolved ghat we are going to follow https://github.com/w3c/trace-context-binary for our own interface, I am closing this issue for now. |
the issue is still there. Current spec expect that formatter can format context into a single bytes blob where spec is written for multiple fields. |
This is covered in #426, which raises several points about the need for more specification about binary propagation. These will be addressed in the next milestone. |
…clang-format (open-telemetry#11) * Build env setup scripts * Remove sqlite for now * Reduce the scope of .clang-format .gitattributes and .gitignore changes * Fix code comment
* Document global initializion * Global initializer requirements * Minor revision * Set status * Rename 0010-global-init.md to text/0005-global-init.md * OTr->OTel
* Document global initializion * Global initializer requirements * Minor revision * Set status * Rename 0010-global-init.md to text/0005-global-init.md * OTr->OTel
Current implementation of binary context inject/extract expects that entire SpanContext can be encoded in a single field:
https://github.com/bogdandrutu/openconsensus/blob/42f90bf8196cc1e3913510160cdfdc3995a7119d/api/src/main/java/openconsensus/context/propagation/BinaryFormat.java#L26-L33
However current proposal lists
traceparent
andtracestate
as separate headers. See w3c/trace-context-binary#7 with the proposal to change itThe text was updated successfully, but these errors were encountered: