Skip to content

Commit

Permalink
Prefer global limit over model-specific default (#1893)
Browse files Browse the repository at this point in the history
  • Loading branch information
owais authored Sep 14, 2021
1 parent efbcc0d commit e139901
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ release.

### Traces

- Prefer global user defined limits over model-sepcific default values.
([#1893](https://github.com/open-telemetry/opentelemetry-specification/pull/1893))
- Add InstrumentationLibrary to Sampler.ShouldSample.
([#1850](https://github.com/open-telemetry/opentelemetry-specification/pull/1850))

Expand Down
5 changes: 3 additions & 2 deletions specification/common/common.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,9 @@ in the list below.
An SDK MAY implement model-specific limits, for example
`SpanAttributeCountLimit`. If both a general and a model-specific limit are
implemented, then the SDK MUST first attempt to use the model-specific limit, if
it isn't set and doesn't have a default, then the SDK MUST attempt to use the
general limit.
it isn't set, then the SDK MUST attempt to use the general limit. If neither are
defined, then the SDK MUST try to use the model-specific limit default value,
followed by the global limit default value.

<a name="attribute-limits-configuration"></a>
**Configurable parameters:**
Expand Down

0 comments on commit e139901

Please sign in to comment.