feat(jaeger): remove internal message queue between exporter and exporting tasks #848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#781 introduced an internal queue between jaeger exporter's
export
method and uploader that actually handles the exporting because Uploader'supload
methods takes a mutable reference and hence cannot be called concurrently.The internal queue helped unblock #781 but has following problems:
Send + Sync
thus the queue is not needed.This PR proposes that:
upload
takes immutable self so that we can call it concurrently.