-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for v0.18.0 release #779
Conversation
Codecov ReportBase: 66.6% // Head: 66.6% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #779 +/- ##
=====================================
Coverage 66.6% 66.6%
=====================================
Files 113 113
Lines 8783 8783
=====================================
Hits 5850 5850
Misses 2933 2933 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hm, not sure if this is a good idea. The way Cargo version resolution, it considers pre-releases semver-compatible with other pre-releases for the same release. Thus, if you release this and there would later be a 1.0.0-beta.2 with any semver-incompatible changes in it, you would break all downstream users. |
@djc good point, is there a better beta convention? |
Hmm, can't think of anything that's widely used in the Rust ecosystem. What is the point of calling it beta? I'd probably just bump the minor version and communicate the status against the spec in the release notes. |
+1 on release using 0.x version and adding notes to communicate this is a beta 1.0 release. Also, I don't think the VERSIONING.md is clear about what we are stabilizing(should only be the |
Do we want to wait for #781 as it has an API change? |
I think that would make sense. |
Any chance this will land soon? We are eagerly awaiting the new version. 😄 |
Should be soon hopefully, just have to resolve the MSRV issues on main |
# Conflicts: # opentelemetry-api/Cargo.toml # opentelemetry-aws/Cargo.toml # opentelemetry-contrib/Cargo.toml # opentelemetry-datadog/Cargo.toml # opentelemetry-http/Cargo.toml # opentelemetry-jaeger/Cargo.toml # opentelemetry-sdk/Cargo.toml # opentelemetry-stackdriver/Cargo.toml
@open-telemetry/rust-approvers should we wait for the current open PRs to land? or merge this sooner than that. |
I think we should include #833 as it includes a fairly important fix for sampling IMO |
I'll make sure to get that finished , theres also a change in the samplers which I can adjust there as well. |
# Conflicts: # opentelemetry-dynatrace/Cargo.toml # opentelemetry-jaeger/CHANGELOG.md # opentelemetry-jaeger/Cargo.toml # opentelemetry-sdk/CHANGELOG.md # opentelemetry-stackdriver/Cargo.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, 🚢!
@djc need a 👍 to merge 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛳️
See VERSIONING.md for what is being stabilized.