-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(otlp,sdk): add schema_url to tracer. #743
Conversation
@TommyCpp should we add this to the |
Codecov Report
@@ Coverage Diff @@
## main #743 +/- ##
==========================================
+ Coverage 70.12% 70.20% +0.08%
==========================================
Files 108 108
Lines 8789 8804 +15
==========================================
+ Hits 6163 6181 +18
+ Misses 2626 2623 -3
Continue to review full report at Codecov.
|
Good point. But I think semantically it isn't used to describe the instrumentation library. Also, we will need to add it to Maybe we can remove the instrumentation library as a struct and just use |
@TommyCpp other impls seem to add it to both |
…hema_url to InstrumentationLibrary.
9239756
to
559c11c
Compare
part of #711
We have already introduced the
schema_url
parameters when we created the tracer. This PR pass it to the protos when exporting in OTLP format. See https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/trace/v1/trace.proto#L71-L72