Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for v0.15.0 release #572

Merged
merged 3 commits into from
Jun 17, 2021
Merged

Prepare for v0.15.0 release #572

merged 3 commits into from
Jun 17, 2021

Conversation

jtescher
Copy link
Member

No description provided.

@jtescher jtescher requested a review from a team June 13, 2021 20:46
@codecov
Copy link

codecov bot commented Jun 13, 2021

Codecov Report

Merging #572 (2f3dacd) into main (6834b64) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #572   +/-   ##
=====================================
  Coverage   54.7%   54.7%           
=====================================
  Files        101     101           
  Lines       8668    8668           
=====================================
  Hits        4745    4745           
  Misses      3923    3923           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6834b64...2f3dacd. Read the comment docs.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Just need to regenerate the grpc file.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that we may want to change is the current OTLP metric exporter is broken in some cases because the collector hasn't updated to the latest version.

For the record, the proto submodule has to be checked out to commit 8ab21ed9a to have it working.

Maybe we should downgrade first to match the collector?

@jtescher
Copy link
Member Author

@TommyCpp should we merge this now? could be nice to have a little more time to consider #571

@TommyCpp
Copy link
Contributor

TommyCpp commented Jun 17, 2021

I think it's good to merge as it is. The only two things that could be added is:

@jtescher jtescher merged commit d7ba1ea into main Jun 17, 2021
@jtescher jtescher deleted the release branch June 17, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants