-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otlp: spawn thread to create blocking reqwest client #2431
otlp: spawn thread to create blocking reqwest client #2431
Conversation
I still need to test this, just getting this up to make sure its not off track. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2431 +/- ##
=====================================
Coverage 79.4% 79.4%
=====================================
Files 122 122
Lines 21697 21700 +3
=====================================
+ Hits 17240 17247 +7
+ Misses 4457 4453 -4 ☔ View full report in Codecov by Sentry. |
Thanks @pitoniak32. You can uncomment the integration test for reqwest-blocking to verify if it functions correctly with these changes? This mayn't necessarily work as there could be some issue with the integration test, I can check that separately in that case. |
@pitoniak32 @lalitb |
thanks @cijothomas. That makes me realize that the |
I can confirm these changes also work for batch log exporter modeled as separate thread in #2436. |
Some(Arc::new(reqwest::blocking::Client::new()) as Arc<dyn HttpClient>) | ||
}) | ||
.join() | ||
.expect("creating reqwest::blocking::Client on a new thread not to fail"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe revisit this, to do an internal error log, and store None.?
fixes #2400
Changes
Using a new thread to create reqwest blocking client to avoid panics from async main
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes