-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: use rstest for table testing sdk resource #2407
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2407 +/- ##
=======================================
- Coverage 79.3% 79.3% -0.1%
=======================================
Files 123 123
Lines 21566 21535 -31
=======================================
- Hits 17112 17082 -30
+ Misses 4454 4453 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@open-telemetry/rust-approvers Please share your thoughts. We try to avoid any external dependency in the shipped code, but for tests/infra, this is acceptable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always favor table driven test methods so 👍 on this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much cleaner. I anticipate it would be more helpful for metrics tests.
fixes: #2384
Changes
Described more in the aboved linked issue. But the goal here is using rstest to improve the test writing experience and allow for tests to have multiple cases in a more readable format.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes