Changelog for switching periodreader default #2399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2399 +/- ##
=====================================
Coverage 79.3% 79.3%
=====================================
Files 123 123
Lines 21566 21566
=====================================
Hits 17112 17112
Misses 4454 4454 ☔ View full report in Codecov by Sentry. |
cijothomas
commented
Dec 9, 2024
| ``` | ||
| - *After:* | ||
| ```rust | ||
| let reader = PeriodicReader::builder(exporter).build(); |
There was a problem hiding this comment.
OTLP Exporter has to default to HTTP and should use request-blocking client as default for this to work.
Add a todo here, to talk about what the user should be doing if they need to use tonic, similar to comments from #2394
|
Closing in favor of #2403 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes not yet in, just seeing how the changelog would look like and get some feedback.