Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modify LogExporter and TraceExporter interfaces to support returning failure #2381

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

more error changes

3c68efa
Select commit
Loading
Failed to load commit list.
Open

chore: modify LogExporter and TraceExporter interfaces to support returning failure #2381

more error changes
3c68efa
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 20, 2024 in 0s

76.8% (+0.7%) compared to 0fc0764

View this Pull Request on Codecov

76.8% (+0.7%) compared to 0fc0764

Details

Codecov Report

Attention: Patch coverage is 58.46154% with 27 lines in your changes missing coverage. Please review.

Project coverage is 76.8%. Comparing base (0fc0764) to head (3c68efa).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/logs/error.rs 0.0% 4 Missing ⚠️
opentelemetry-otlp/src/exporter/http/logs.rs 0.0% 3 Missing ⚠️
opentelemetry-otlp/src/exporter/http/trace.rs 0.0% 3 Missing ⚠️
opentelemetry-sdk/src/export/trace.rs 50.0% 3 Missing ⚠️
opentelemetry-sdk/src/logs/log_processor.rs 66.6% 3 Missing ⚠️
opentelemetry-otlp/src/exporter/tonic/logs.rs 0.0% 2 Missing ⚠️
opentelemetry-otlp/src/exporter/tonic/trace.rs 0.0% 2 Missing ⚠️
opentelemetry-sdk/src/trace/span_processor.rs 75.0% 2 Missing ⚠️
opentelemetry-stdout/src/logs/exporter.rs 0.0% 2 Missing ⚠️
opentelemetry-stdout/src/trace/exporter.rs 0.0% 2 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #2381     +/-   ##
=======================================
+ Coverage   76.1%   76.8%   +0.7%     
=======================================
  Files        122     122             
  Lines      22066   22244    +178     
=======================================
+ Hits       16793   17097    +304     
+ Misses      5273    5147    -126

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov