-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace OtlpPipeline with exporter builders #2221
base: main
Are you sure you want to change the base?
feat: replace OtlpPipeline with exporter builders #2221
Conversation
I have started looking into replicating If you have a chance to review this @cijothomas I would really appreciate it! |
a307f3d
to
4f44160
Compare
This might be another issue / PR, but I'm noticing the |
414dfac
to
dfeb006
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2221 +/- ##
=======================================
+ Coverage 79.3% 79.7% +0.4%
=======================================
Files 121 121
Lines 20944 20858 -86
=======================================
+ Hits 16612 16640 +28
+ Misses 4332 4218 -114 ☔ View full report in Codecov by Sentry. |
dfeb006
to
b4b5118
Compare
Yes, ensuring consistency across signals wherever feasible is definitely something we need to tackle soon! |
.unwrap(); | ||
|
||
let provider = opentelemetry_sdk::logs::LoggerProvider::builder() | ||
.with_batch_exporter(exporter, opentelemetry_sdk::runtime::Tokio) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this direction.
@@ -11,7 +11,7 @@ use super::data::Temporality; | |||
/// | |||
/// This is the final component in the metric push pipeline. | |||
#[async_trait] | |||
pub trait PushMetricsExporter: Send + Sync + 'static { | |||
pub trait PushMetricExporter: Send + Sync + 'static { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets do this in its own PR, to keep the scope for each PR very focused.
@@ -28,7 +28,7 @@ static RESOURCE: Lazy<Resource> = Lazy::new(|| { | |||
fn init_trace() { | |||
let exporter = opentelemetry_stdout::SpanExporter::default(); | |||
let provider = TracerProvider::builder() | |||
.with_simple_exporter(exporter) | |||
.with_batch_exporter(exporter, runtime::Tokio) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets keep it simple itself. stdout is only for learning purposes. and simple exporter is also only meant for that.
@@ -66,7 +66,7 @@ pub(crate) mod tonic; | |||
|
|||
/// Configuration for the OTLP exporter. | |||
#[derive(Debug)] | |||
pub struct ExportConfig { | |||
pub struct ExporterConfig { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also suggest to keep the renaming to a separate, small pr, so it is easier to review.
Took a brief look and I like this direction. Left some comments, mostly about limiting the scope of PR. We really prefer short PRs each solving one particular aspect. |
I'll go through and remove some of the changes I made that weren't specific to this issue 👍 |
b4b5118
to
c075527
Compare
Fixes #1810
Changes
Started to replace the
OTLPPipeline
pattern in theopentelemetry-otlp
crate.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes