-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keys method to extractors #209
Conversation
@siyopao great start! What do you think about having |
Thanks for the comment @jtescher. Good idea! I've updated to return an iterator. |
@siyopao Sorry I hadn't looked into this closely enough, I don't think we can have this be an iterator without additional allocations as the lifetimes for something like |
I agree. There is no guarantee how extractors will store those keys. So we may as well use |
This reverts commit 846e3e6.
No worries. Reverted that commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok looks good 👍
First attempt at #195. I could probably use some help with the documentation though 🙇
Closes #195.